From: Arnd Bergmann <arnd@arndb.de>
To: David Ahern <dsahern@gmail.com>
Cc: David Miller <davem@davemloft.net>,
cwang@twopensource.com, netdev@vger.kernel.org,
kyeyoonp@codeaurora.org, bridge@lists.linux-foundation.org,
stephen@networkplumber.org
Subject: Re: [PATCH] bridge: only provide proxy ARP when CONFIG_INET is enabled
Date: Tue, 13 Jan 2015 22:33:48 +0100 [thread overview]
Message-ID: <4681500.x6CYopasp1@wuerfel> (raw)
In-Reply-To: <54B58AAC.7090001@gmail.com>
On Tuesday 13 January 2015 14:14:20 David Ahern wrote:
>
> Rather than connect CONFIG_BRIDGE to CONFIG_INET, why not make
> br_do_proxy_arp (and setting BR_PROXYARP flag) a no-op if CONFIG_INET is
> not set?
>
> #ifdef CONFIG_INET
> #else
> static inline void br_do_proxy_arp(...args...)
> {
> }
> #endif
>
> That covers both arp_tbl and arp_send.
The effect is very similar to my patch (probably same object code), the
only difference should be that it would add an ugly #ifdef instead of
the preferred IS_ENABLED() check, so you don't get any compile-time
coverage of the function. It's not really important because everybody
has CONFIG_INET enabled in practice and it does get more than enough
compile-time coverage.
Arnd
next prev parent reply other threads:[~2015-01-13 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:10 [PATCH] bridge: only provide proxy ARP when CONFIG_INET is enabled Arnd Bergmann
2015-01-13 19:25 ` Cong Wang
2015-01-13 20:57 ` David Miller
2015-01-13 21:14 ` David Ahern
2015-01-13 21:33 ` Arnd Bergmann [this message]
2015-01-14 2:56 ` David Ahern
2015-01-14 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4681500.x6CYopasp1@wuerfel \
--to=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kyeyoonp@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox