From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org,
"bugme-daemon@kernel-bugs.osdl.org"
<bugme-daemon@kernel-bugs.osdl.org>,
ranko@spidernet.net
Subject: Re: [Bugme-new] [Bug 8668] New: HTB Deadlock
Date: Wed, 27 Jun 2007 13:44:08 +0200 [thread overview]
Message-ID: <46824D88.1090300@trash.net> (raw)
In-Reply-To: <20070627114521.GA3762@ff.dom.local>
Jarek Poplawski wrote:
> On 25-06-2007 11:28, Patrick McHardy wrote:
> ...
>
>> It is. This patch I had originally planned for 2.6.23 switches HTB
>> to the generic estimator, which shouldn't suffer from this.
>>
>
> BTW, maybe I look at this too short, but is this del_timer()
> in gen_kill_estimator() enough? I cannot see nothing against
> a timer just running and doing mod_timer() again...
Yes, but nothing bad can happen, the timer will find an empty
list and do nothing. It would make more sense to check for
an empty list before restarting the timer though.
Could you send a patch for that?
next prev parent reply other threads:[~2007-06-27 11:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-8668-10286@http.bugzilla.kernel.org/>
2007-06-25 5:24 ` [Bugme-new] [Bug 8668] New: HTB Deadlock Andrew Morton
2007-06-25 9:28 ` Patrick McHardy
2007-06-25 9:30 ` Patrick McHardy
2007-06-25 11:37 ` Ranko Zivojnovic
2007-06-27 11:45 ` Jarek Poplawski
2007-06-27 11:44 ` Patrick McHardy [this message]
2007-06-27 12:10 ` Jarek Poplawski
2007-06-27 12:30 ` Jarek Poplawski
2007-06-27 14:53 ` Patrick McHardy
2007-06-27 15:09 ` [NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock] Patrick McHardy
2007-06-27 15:25 ` Patrick McHardy
2007-06-28 6:54 ` Jarek Poplawski
2007-06-28 9:56 ` Jarek Poplawski
2007-06-28 9:13 ` Jarek Poplawski
2007-06-28 12:23 ` Patrick McHardy
2007-06-28 13:03 ` Jarek Poplawski
2007-06-28 12:55 ` Patrick McHardy
2007-06-28 13:27 ` Jarek Poplawski
2007-06-29 7:02 ` Jarek Poplawski
2007-06-29 7:56 ` Jarek Poplawski
2007-06-28 7:52 ` [Bugme-new] [Bug 8668] New: HTB Deadlock Jarek Poplawski
2007-06-28 12:24 ` Patrick McHardy
2007-06-28 13:18 ` Jarek Poplawski
2007-06-28 13:16 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46824D88.1090300@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@kernel-bugs.osdl.org \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
--cc=ranko@spidernet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).