From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API Date: Thu, 28 Jun 2007 21:37:25 +0200 Message-ID: <46840DF5.7010204@trash.net> References: <468409E4.7000603@trash.net> <46840CD8.7000308@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: "Waskiewicz Jr, Peter P" , davem@davemloft.net, netdev@vger.kernel.org, "Kok, Auke-jan H" , hadi@cyberus.ca To: Jeff Garzik Return-path: Received: from stinky.trash.net ([213.144.137.162]:58073 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763637AbXF1TiZ (ORCPT ); Thu, 28 Jun 2007 15:38:25 -0400 In-Reply-To: <46840CD8.7000308@garzik.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jeff Garzik wrote: > Patrick McHardy wrote: > >> Yes, but there are users that don't go through qdiscs, like netpoll, >> Having them check the QDISC_RUNNING bit seems ugly. > > > Is netpoll the only such user? I'm not sure, I just remembered that one :) Looking at Peter's multiqueue patch, which should include all hard_start_xmit users (I'm not seeing sch_teql though, Peter?) the only other one is pktgen. > netpoll tends to be a special case in every sense of the word, and I > wish it was less so :/ Indeed.