From: Jeff Garzik <jgarzik@pobox.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, Edward Hsu <edward_hsu@realtek.com.tw>
Subject: Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver
Date: Fri, 29 Jun 2007 16:49:44 -0400 [thread overview]
Message-ID: <46857068.4050803@pobox.com> (raw)
In-Reply-To: <1183149335.2642.10.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
>> + pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);
>
> can you create a pci_set_latency_timer() for this please?
>
>> +
>> + if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
>> + pci_write_config_byte(tp->pci_dev, PCI_CACHE_LINE_SIZE, 0x08);
>
> and something for this as well?
Why? Nothing here seems generic to me.
Jeff
next prev parent reply other threads:[~2007-06-29 20:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 20:12 [PATCH 00/21] r8169: pull request for 'r8169-for-jeff-20070629' branch Francois Romieu
2007-06-29 20:13 ` [PATCH 01/21] r8169: use netdev_alloc_skb Francois Romieu
2007-06-29 20:17 ` [PATCH 02/21] r8169: de-obfuscate modulo arithmetic Francois Romieu
2007-06-29 20:17 ` [PATCH 03/21] r8169: kill eth_copy_and_sum() Francois Romieu
2007-06-29 20:18 ` [PATCH 04/21] r8169: Rx path update Francois Romieu
2007-06-29 20:23 ` [PATCH 05/21] r8169: add hooks for per-device hw_start handler Francois Romieu
2007-06-29 20:23 ` [PATCH 06/21] r8169: add helpers " Francois Romieu
2007-06-29 20:23 ` [PATCH 07/21] r8169: populate the hw_start handler for the 8168 Francois Romieu
2007-06-29 20:24 ` [PATCH 08/21] r8169: populate the hw_start handler for the 8110 Francois Romieu
2007-06-29 20:24 ` [PATCH 09/21] r8169: prettify mac_version Francois Romieu
2007-06-29 20:25 ` [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver Francois Romieu
2007-06-29 20:35 ` Arjan van de Ven
2007-06-29 20:49 ` Jeff Garzik [this message]
2007-06-30 9:41 ` Francois Romieu
2007-06-30 9:47 ` Jeff Garzik
2007-06-30 14:43 ` Arjan van de Ven
2007-06-29 20:25 ` [PATCH 11/21] r8169: merge with version 8.001.00 of Realtek's r8168 driver Francois Romieu
2007-06-29 20:25 ` [PATCH 12/21] r8169: confusion between hardware and IP header alignment Francois Romieu
2007-11-23 7:45 ` Martin Michlmayr
2007-11-25 23:05 ` Francois Romieu
2007-11-26 8:36 ` Martin Michlmayr
2007-11-26 22:42 ` Francois Romieu
2007-06-29 20:26 ` [PATCH 13/21] r8169: small 8101 comment Francois Romieu
2007-06-29 20:26 ` [PATCH 14/21] r8169: remove the media option Francois Romieu
2007-06-29 20:27 ` [PATCH 15/21] r8169: cleanup Francois Romieu
2007-06-29 20:27 ` [PATCH 16/21] r8169: add bit description for the TxPoll register Francois Romieu
2007-06-29 20:27 ` [PATCH 17/21] r8169: align the IP header when there is no DMA constraint Francois Romieu
2007-06-29 20:28 ` [PATCH 18/21] r8169: add endianess annotations to [RT]xDesc Francois Romieu
2007-06-29 20:28 ` [PATCH 19/21] r8169: display some extra debug information during startup Francois Romieu
2007-06-29 20:29 ` [PATCH 20/21] r8169: mac address change support Francois Romieu
2007-06-29 20:29 ` [PATCH 21/21] r8169: perform RX config change after mac filtering Francois Romieu
2007-06-29 20:48 ` [PATCH 00/21] r8169: pull request for 'r8169-for-jeff-20070629' branch Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46857068.4050803@pobox.com \
--to=jgarzik@pobox.com \
--cc=arjan@infradead.org \
--cc=edward_hsu@realtek.com.tw \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).