From: Patrick McHardy <kaber@trash.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: Handling set_mac_address in set_rx_mode
Date: Mon, 02 Jul 2007 14:20:16 +0200 [thread overview]
Message-ID: <4688ED80.4090105@trash.net> (raw)
In-Reply-To: <4686BF35.8080605@garzik.org>
Jeff Garzik wrote:
> Patrick McHardy wrote:
>
>> While adding support for secondary unicast addresses to 8021q and
>> macvlan, I've tried keeping dev->dev_addr as global address on
>> dev->uc_list and have drivers skip them to avoid having all
>> dev_unicast_add users implement a state machine like this:
>
>
> [...]
>
> Something that is not entirely clear to me... This has zero impact on
> existing drivers, right?
Yes, since the set_rx_mode hook is new anyway this would only
affect drivers offering it (which is none so far). But this
idea turned not to be so good anyways, without the
set_mac_address callback the driver can't validate the new
address.
prev parent reply other threads:[~2007-07-02 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 18:51 Handling set_mac_address in set_rx_mode Patrick McHardy
2007-06-30 20:38 ` Jeff Garzik
2007-07-02 12:20 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4688ED80.4090105@trash.net \
--to=kaber@trash.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).