* [PATCH] dm9601: HW header size shouldn't be included in packet length
@ 2007-06-27 6:14 Peter Korsgaard
2007-07-02 12:25 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2007-06-27 6:14 UTC (permalink / raw)
To: netdev, jeff
The dm9601 driver was including the 2 byte hardware header in the
packet length, causing the HW to send 2 extra bytes of garbage on tx.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/net/usb/dm9601.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6.22-rc6/drivers/net/usb/dm9601.c
===================================================================
--- linux-2.6.22-rc6.orig/drivers/net/usb/dm9601.c
+++ linux-2.6.22-rc6/drivers/net/usb/dm9601.c
@@ -489,6 +489,8 @@
b3..n: packet data
*/
+ len = skb->len;
+
if (skb_headroom(skb) < DM_TX_OVERHEAD) {
struct sk_buff *skb2;
@@ -501,10 +503,9 @@
__skb_push(skb, DM_TX_OVERHEAD);
- len = skb->len;
/* usbnet adds padding if length is a multiple of packet size
if so, adjust length value in header */
- if ((len % dev->maxpacket) == 0)
+ if ((skb->len % dev->maxpacket) == 0)
len++;
skb->data[0] = len;
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dm9601: HW header size shouldn't be included in packet length
2007-06-27 6:14 [PATCH] dm9601: HW header size shouldn't be included in packet length Peter Korsgaard
@ 2007-07-02 12:25 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-07-02 12:25 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: netdev
Peter Korsgaard wrote:
> The dm9601 driver was including the 2 byte hardware header in the
> packet length, causing the HW to send 2 extra bytes of garbage on tx.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>
> ---
> drivers/net/usb/dm9601.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-02 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-27 6:14 [PATCH] dm9601: HW header size shouldn't be included in packet length Peter Korsgaard
2007-07-02 12:25 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).