From: Jeff Garzik <jgarzik@pobox.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Russell King <rmk@arm.linux.org.uk>,
netfilter-devel@lists.netfilter.org,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: 2.6.22-rc6: local_bh_enable warning
Date: Mon, 02 Jul 2007 10:22:04 -0400 [thread overview]
Message-ID: <46890A0C.1060801@pobox.com> (raw)
In-Reply-To: <468906DC.3010709@trash.net>
Patrick McHardy wrote:
> Russell King wrote:
>> Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
>>
>> Looks like netfilter is calling local_bh_enable() with IRQs disabled,
>> which would appear to be illegal. Thankfully, this is a warn-once
>> warning.
>>
>> WARNING: at /home/rmk/git/linux-2.6-rmk/kernel/softirq.c:138 local_bh_enable()
>> [...]
>> [<c01447fc>] (nf_conntrack_destroy+0x0/0x2c) from [<c012c05c>] (__kfree_skb+0xd0/0x100)
>> [<c012bf8c>] (__kfree_skb+0x0/0x100) from [<c012c0d8>] (kfree_skb+0x4c/0x50)
>> r5:c12a3800 r4:00000300
>> [<c012c08c>] (kfree_skb+0x0/0x50) from [<bf03cbb0>] (el3_start_xmit+0xb8/0xd0 [3c589_cs])
>> [<bf03caf8>] (el3_start_xmit+0x0/0xd0 [3c589_cs]) from [<c01324dc>] (dev_hard_start_xmit+0x1a8/0x244)
>> r7:c12a3800 r6:c1a9aa00 r5:c1a9aa00 r4:c12a3800
>> [<c0132334>] (dev_hard_start_xmit+0x0/0x244) from [<c013fcc0>] (__qdisc_run+0xb0/0x198)
>
>
> Thats a bug in the 3c589_cs driver. Patch attached.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
You would post this JUST after I finished my patch applying run,
wouldn't you? :)
Will apply in a few minutes, thanks :)
Jeff
prev parent reply other threads:[~2007-07-02 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070630170853.GA17467@flint.arm.linux.org.uk>
2007-07-02 14:08 ` 2.6.22-rc6: local_bh_enable warning Patrick McHardy
2007-07-02 14:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46890A0C.1060801@pobox.com \
--to=jgarzik@pobox.com \
--cc=kaber@trash.net \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).