From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: 2.6.22-rc6: local_bh_enable warning Date: Mon, 02 Jul 2007 10:22:04 -0400 Message-ID: <46890A0C.1060801@pobox.com> References: <20070630170853.GA17467@flint.arm.linux.org.uk> <468906DC.3010709@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Russell King , netfilter-devel@lists.netfilter.org, Michal Piotrowski , Linux Netdev List To: Patrick McHardy Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:52012 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753615AbXGBOWi (ORCPT ); Mon, 2 Jul 2007 10:22:38 -0400 In-Reply-To: <468906DC.3010709@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Patrick McHardy wrote: > Russell King wrote: >> Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following. >> >> Looks like netfilter is calling local_bh_enable() with IRQs disabled, >> which would appear to be illegal. Thankfully, this is a warn-once >> warning. >> >> WARNING: at /home/rmk/git/linux-2.6-rmk/kernel/softirq.c:138 local_bh_enable() >> [...] >> [] (nf_conntrack_destroy+0x0/0x2c) from [] (__kfree_skb+0xd0/0x100) >> [] (__kfree_skb+0x0/0x100) from [] (kfree_skb+0x4c/0x50) >> r5:c12a3800 r4:00000300 >> [] (kfree_skb+0x0/0x50) from [] (el3_start_xmit+0xb8/0xd0 [3c589_cs]) >> [] (el3_start_xmit+0x0/0xd0 [3c589_cs]) from [] (dev_hard_start_xmit+0x1a8/0x244) >> r7:c12a3800 r6:c1a9aa00 r5:c1a9aa00 r4:c12a3800 >> [] (dev_hard_start_xmit+0x0/0x244) from [] (__qdisc_run+0xb0/0x198) > > > Thats a bug in the 3c589_cs driver. Patch attached. > > Signed-off-by: Patrick McHardy You would post this JUST after I finished my patch applying run, wouldn't you? :) Will apply in a few minutes, thanks :) Jeff