netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marian Balakowicz <m8@semihalf.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: bjorn.helgaas@hp.com, linux-pci@atrey.karlin.mff.cuni.cz,
	len.brown@intel.com, NetDev <netdev@vger.kernel.org>
Subject: [PATCH] PCI: quirk_e100_interrupt() called too early
Date: Tue, 03 Jul 2007 11:03:18 +0200	[thread overview]
Message-ID: <468A10D6.2020900@semihalf.com> (raw)
In-Reply-To: <4683DB44.9070704@intel.com>

quirk_e100_interrupts() is called after PCI controller is initialized
and before PCI bus enumeration is performed. On some powerpc platforms
which modify PCI controller configuration and set different MEM and IO
windows than those set by firmware quirk_e100_interrupt() is causing
kernel panic as it tries to read from device BAR0 offets which at this
time points to a invalid PCI window (set by firmware).

This patch delays the quirk_100_interrupt() to pci_fixup_final phase,
which happens after bus enumeration and before PCI enable and
device driver initialization.

Signed-off-by: Marian Balakowicz <m8@semihalf.com>
---

 drivers/pci/quirks.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 01d8f8a..7194074 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1475,7 +1475,7 @@ static void __devinit quirk_e100_interru

 	iounmap(csr);
 }
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, quirk_e100_interrupt);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, quirk_e100_interrupt);

 static void __devinit fixup_rev1_53c810(struct pci_dev* dev)
 {




  parent reply	other threads:[~2007-07-03  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4683A80F.5020605@semihalf.com>
2007-06-28 16:01 ` quirk_e100_interrupt() called too early Kok, Auke
2007-06-29  2:07   ` Bjorn Helgaas
2007-07-02  8:07     ` Nils Rennebarth
2007-07-02 19:03       ` Kok, Auke
2007-07-03  9:00   ` Marian Balakowicz
2007-07-03  9:03   ` Marian Balakowicz [this message]
2007-07-17 17:21     ` patch pci-quirk_e100_interrupt-called-too-early.patch added to gregkh-2.6 tree gregkh
2007-07-17 17:26       ` Kok, Auke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468A10D6.2020900@semihalf.com \
    --to=m8@semihalf.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=len.brown@intel.com \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).