netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev <netdev@vger.kernel.org>, jamal <hadi@cyberus.ca>,
	Thomas Graf <tgraf@suug.ch>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: multicasting netlink messages to groups > 31 from userspace
Date: Thu, 05 Jul 2007 15:37:34 +0200	[thread overview]
Message-ID: <468CF41E.4020409@trash.net> (raw)
In-Reply-To: <1183561713.9662.5.camel@johannes.berg>

Johannes Berg wrote:
> On Wed, 2007-07-04 at 17:00 +0200, Patrick McHardy wrote:
> 
> 
>>Not by itself probably but a user could DoS your wireless connectivity
>>this way.
> 
> 
> Hmm, if anything then not the connectivity but rather the MLME i.e. it
> won't do roaming properly maybe. Maybe we should then have a way to say
> that somebody only wants to receive messages from privileged users, that
> way the MLME process wouldn't be affected.


Earlier filtering makes sense, especially for userspace. The other
part exceeds my wireless knowledge :)

>>I'm not sure, it would probably also have to be called when userspace
>>unsubscribes from a group, no?
> 
> 
> No actually having that hook means I can do without multicast groups by
> just publishing that "send configuration requests to pid N" where N is
> either 0 (in-kernel MLME) or something else (userspace MLME); I just
> didn't know the hook existed.


Even better. Publishing that to userspace is going to be racy though.

> Not that we shouldn't fix the multicast issues anyway though the one
> from this particular thread wouldn't be too interesting right now until
> somebody needs userspace to multicast; the other three patches still
> should be done now before there are more generic netlink multicast
> users.


The genetlink stuff defintely makes sense. I'll have a closer look at
your patches this weekend.


  reply	other threads:[~2007-07-05 13:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 19:51 multicasting netlink messages to groups > 31 from userspace Johannes Berg
2007-07-04 12:04 ` Evgeniy Polyakov
2007-07-04 13:54   ` Johannes Berg
2007-07-04 14:12 ` Patrick McHardy
2007-07-04 14:18   ` Johannes Berg
2007-07-04 14:30     ` Patrick McHardy
2007-07-04 14:38       ` Johannes Berg
2007-07-04 14:48         ` Patrick McHardy
2007-07-04 14:56           ` Johannes Berg
2007-07-04 15:00             ` Patrick McHardy
2007-07-04 15:08               ` Johannes Berg
2007-07-05 13:37                 ` Patrick McHardy [this message]
2007-07-06 10:53                   ` Johannes Berg
2007-07-06 15:08                     ` jamal
2007-07-05 13:53 ` jamal
2007-07-05 14:08   ` Patrick McHardy
2007-07-06 10:50   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468CF41E.4020409@trash.net \
    --to=kaber@trash.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).