From: Jeff Garzik <jeff@garzik.org>
To: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
Michael Buesch <mb@bu3sch.de>,
Christoph Hellwig <hch@infradead.org>,
Stephen Hemminger <shemminger@linux-foundation.org>,
"Veeraiyan, Ayyappan" <ayyappan.veeraiyan@intel.com>,
netdev@vger.kernel.org, arjan@linux.intel.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...
Date: Thu, 05 Jul 2007 19:29:01 -0400 [thread overview]
Message-ID: <468D7EBD.7020103@garzik.org> (raw)
In-Reply-To: <200707031124.24529.inaky@linux.intel.com>
Inaky Perez-Gonzalez wrote:
> On Tuesday 03 July 2007, Jeff Garzik wrote:
>> Inaky Perez-Gonzalez wrote:
>> Access to bitfields are not atomic within the machine int in which they
>> are stored... you need to "unpack" the values stored in bitfields, even
>> if they are single-bit bitfields.
>
> Which we do manually when we don't use bitfields. Again, conceptually,
> there is no difference.
Practically speaking -- there are differences.
The "manual" method hides nothing from the programmer, while use of
bitfields hides the lack of atomicity.
When you have programmers who make mistakes -- i.e. real humans -- these
things matter.
But overall, it is not any one detail that discourages use of bitfields;
it is the sum of all the reasons. Practical experience, compiler
technology, mistakes made (and not made), all point to avoiding bitfields.
Jeff
next prev parent reply other threads:[~2007-07-05 23:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:44 [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters Ayyappan.Veeraiyan
2007-06-12 23:44 ` [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based " Ayyappan Veeraiyan
2007-07-02 12:52 ` Jeff Garzik
2007-07-02 14:05 ` Arjan van de Ven
2007-07-02 14:25 ` Jeff Garzik
2007-07-02 14:27 ` Arjan van de Ven
2007-07-02 14:41 ` Jeff Garzik
2007-07-02 14:41 ` Arjan van de Ven
2007-07-02 15:26 ` Kok, Auke
2007-07-02 15:32 ` Jeff Garzik
2007-07-02 15:52 ` Andrew Morton
2007-07-02 16:09 ` Jeff Garzik
2007-07-02 15:54 ` Kok, Auke
2007-07-06 8:46 ` Ingo Oeser
2007-07-02 14:31 ` Arjan van de Ven
2007-07-02 19:00 ` Veeraiyan, Ayyappan
2007-07-02 19:04 ` Ayyappan Veeraiyan
2007-07-02 20:16 ` Christoph Hellwig
2007-07-02 21:09 ` Stephen Hemminger
2007-07-02 21:42 ` Christoph Hellwig
2007-07-02 22:02 ` Kok, Auke
2007-07-02 22:08 ` Jeff Garzik
2007-07-02 22:10 ` Michael Buesch
2007-07-02 22:16 ` Jeff Garzik
2007-07-02 23:57 ` Kok, Auke
2007-07-03 0:11 ` Jeff Garzik
2007-07-03 0:16 ` Inaky Perez-Gonzalez
2007-07-03 13:19 ` Jeff Garzik
2007-07-03 18:24 ` Inaky Perez-Gonzalez
2007-07-05 23:29 ` Jeff Garzik [this message]
2007-07-03 0:08 ` Veeraiyan, Ayyappan
2007-07-03 22:01 ` Ayyappan Veeraiyan
2007-07-02 22:56 ` Veeraiyan, Ayyappan
2007-07-03 12:53 ` Neil Horman
2007-07-05 12:37 ` Neil Horman
2007-07-09 14:21 ` Veeraiyan, Ayyappan
2007-07-10 0:57 ` Neil Horman
2007-06-13 23:05 ` [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE " Francois Romieu
2007-06-13 23:18 ` Kok, Auke
2007-06-14 0:06 ` Ayyappan Veeraiyan
2007-06-14 20:36 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468D7EBD.7020103@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=ayyappan.veeraiyan@intel.com \
--cc=hch@infradead.org \
--cc=inaky@linux.intel.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).