netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH updated] IPV6: Call inet6addr_chain notifiers on link down
@ 2007-07-06 13:32 Vlad Yasevich
  2007-07-15  7:17 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Vlad Yasevich @ 2007-07-06 13:32 UTC (permalink / raw)
  To: netdev; +Cc: YOSHIFUJI Hideaki / ????, David Miller

Dave

Ok... This one was taken off the the system actually running the patch
so I know this one is correct.  I just retested, turning on temporary
addresses as well, and the notification happen correctly.

I was expecting an ACK from Yoshifuji-san before you applied it so feel
free to wait for it.

-vlad
--

Currently if the link is brought down via ip link or ifconfig down,
the inet6addr_chain notifiers are not called even though all
the addresses are removed from the interface.  This caused SCTP
to add duplicate addresses to it's list.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
 net/ipv6/addrconf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index f96ed76..2cc3728 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2472,6 +2472,7 @@ static int addrconf_ifdown(struct net_device *dev, int how)
 		write_unlock_bh(&idev->lock);
 
 		__ipv6_ifa_notify(RTM_DELADDR, ifa);
+		atomic_notifier_call_chain(&inet6addr_chain, NETDEV_DOWN, ifa);
 		in6_ifa_put(ifa);
 
 		write_lock_bh(&idev->lock);
-- 
1.5.0.3.438.gc49b2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH updated] IPV6: Call inet6addr_chain notifiers on link down
  2007-07-06 13:32 [PATCH updated] IPV6: Call inet6addr_chain notifiers on link down Vlad Yasevich
@ 2007-07-15  7:17 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-07-15  7:17 UTC (permalink / raw)
  To: vladislav.yasevich; +Cc: netdev, yoshfuji

From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 06 Jul 2007 09:32:09 -0400

> Currently if the link is brought down via ip link or ifconfig down,
> the inet6addr_chain notifiers are not called even though all
> the addresses are removed from the interface.  This caused SCTP
> to add duplicate addresses to it's list.
> 
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>

Applied, thanks Vlad.

I'll push this to -stable too.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-07-15  7:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-06 13:32 [PATCH updated] IPV6: Call inet6addr_chain notifiers on link down Vlad Yasevich
2007-07-15  7:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).