From: KII Keiichi <k-keiichi@bx.jp.nec.com>
To: Satyam Sharma <ssatyam@cse.iitk.ac.in>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Joel Becker <joel.becker@oracle.com>,
Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets
Date: Sun, 08 Jul 2007 03:33:49 +0900 [thread overview]
Message-ID: <468FDC8D.6080208@bx.jp.nec.com> (raw)
In-Reply-To: <20070704110814.28520.94417.sendpatchset@cselinux1.cse.iitk.ac.in>
Hi Satyam,
The following comments aren't essential.
> if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> - goto done;
> + goto done;
The above diff lines are extra.
> + spin_lock_irqsave(&target_list_lock, flags);
> + list_for_each_entry(nt, &target_list, list) {
> + if (nt->np.dev == dev) {
> + switch (event) {
> + case NETDEV_UP:
> + case NETDEV_DOWN:
> + nt->dev_status = net_dev_is_up(nt->np.dev);
> + break;
> +
> + case NETDEV_CHANGEADDR:
> + memcpy(nt->np.local_mac, dev->dev_addr, ETH_ALEN);
The above line is over 80 characters.
Thanks,
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: k-keiichi@bx.jp.nec.com
next prev parent reply other threads:[~2007-07-07 18:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 11:07 [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability Satyam Sharma
2007-07-04 11:07 ` [PATCH -mm 1/9] netconsole: Cleanups, codingstyle, prettyfication Satyam Sharma
2007-07-04 11:07 ` [PATCH -mm 2/9] netconsole: Code simplification Satyam Sharma
2007-07-04 13:46 ` Matt Mackall
2007-07-04 17:43 ` Satyam Sharma
2007-07-04 11:07 ` [PATCH -mm 3/9] netconsole: Introduce netconsole_target Satyam Sharma
2007-07-04 11:07 ` [PATCH -mm 4/9] netconsole: Introduce netconsole_netdev_notifier Satyam Sharma
2007-07-04 13:59 ` Matt Mackall
2007-07-04 18:02 ` Satyam Sharma
2007-07-07 18:33 ` KII Keiichi
2007-07-07 20:28 ` Satyam Sharma
2007-07-07 20:49 ` Satyam Sharma
2007-07-04 11:08 ` [PATCH -mm 5/9] netconsole: Introduce dev_status member Satyam Sharma
2007-07-04 13:56 ` Matt Mackall
2007-07-04 16:33 ` Satyam Sharma
2007-07-05 15:17 ` Stephen Hemminger
2007-07-07 8:08 ` Satyam Sharma
2007-07-05 6:39 ` Joel Becker
2007-07-05 9:36 ` Satyam Sharma
2007-07-04 11:08 ` [PATCH -mm 6/9] netconsole: Update documentation for multiple target support Satyam Sharma
2007-07-04 14:01 ` Matt Mackall
2007-07-04 18:11 ` Satyam Sharma
2007-07-04 11:08 ` [PATCH -mm 7/9] netconsole: Support multiple logging targets Satyam Sharma
2007-07-07 18:33 ` KII Keiichi [this message]
2007-07-07 19:46 ` Satyam Sharma
2007-07-04 11:08 ` [PATCH -mm 8/9] netconsole: Update documentation for dynamic reconfigurability Satyam Sharma
2007-07-05 6:52 ` Joel Becker
2007-07-05 9:38 ` Satyam Sharma
2007-07-05 12:58 ` Keiichi KII
2007-07-05 13:55 ` Satyam Sharma
2007-07-05 14:03 ` Satyam Sharma
2007-07-07 18:33 ` KII Keiichi
2007-07-07 20:35 ` Satyam Sharma
2007-07-04 11:08 ` [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs Satyam Sharma
2007-07-04 13:21 ` Satyam Sharma
2007-07-07 6:01 ` Joel Becker
2007-07-07 7:48 ` Satyam Sharma
2007-07-07 8:18 ` Joel Becker
2007-07-07 18:33 ` KII Keiichi
2007-07-07 19:38 ` Satyam Sharma
2007-07-04 11:49 ` [RFC][PATCH -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability Keiichi KII
2007-07-04 12:25 ` Satyam Sharma
2007-07-05 7:04 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468FDC8D.6080208@bx.jp.nec.com \
--to=k-keiichi@bx.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=ssatyam@cse.iitk.ac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).