From: Larry Finger <larry.finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Cc: jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2.6] SoftMAC : fix ESSID problem
Date: Mon, 09 Jul 2007 18:40:44 -0500 [thread overview]
Message-ID: <4692C77C.30005@lwfinger.net> (raw)
In-Reply-To: <200707100046.23832.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Michael Buesch wrote:
> On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
>> Hi,
>>
>> Victor Porton reported that the SoftMAC layer had random
>> problem when setting the ESSID :
>> http://bugzilla.kernel.org/show_bug.cgi?id=8686
>> After investigation, it turned out to be worse, the SoftMAC
>> layer is left in an inconsistent state. The fix is pretty trivial.
>> John : would you mind pushing that to 2.6.23 ?
>> Thanks...
>>
>> Jean
>>
>> Signed-off-by: Jean Tourrilhes <jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org>
>>
>> -----------------------------------------------------------
>>
>> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
>> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
>> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
>> */
>> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
>> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
>> - if (ieee80211softmac_start_scan(mac))
>> + if (ieee80211softmac_start_scan(mac)) {
>> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
>> + mac->associnfo.associating = 0;
>> + mac->associnfo.associated = 0;
>> + }
>> goto out;
>> } else {
>> mac->associnfo.associating = 0;
>>
>
> Acked-by: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Acked-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
This patch should also be sent to stable-DgEjT+Ai2yi4UlQgPVntAg@public.gmane.org
Larry
next prev parent reply other threads:[~2007-07-09 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 22:19 [PATCH 2.6] SoftMAC : fix ESSID problem Jean Tourrilhes
2007-07-09 22:46 ` Michael Buesch
[not found] ` <200707100046.23832.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-07-09 23:40 ` Larry Finger [this message]
[not found] ` <4692C77C.30005-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-07-09 23:44 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4692C77C.30005@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public.gmane.org \
--cc=jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).