* [PATCH] QE Ethernet driver writes to wrong register to mask interrupts
@ 2007-07-10 12:51 Timur Tabi
2007-07-10 12:59 ` Li Yang-r58472
2007-07-10 16:26 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Timur Tabi @ 2007-07-10 12:51 UTC (permalink / raw)
To: jgarzik, netdev; +Cc: Timur Tabi
The QE Ethernet driver was writing to the wrong register to mask interrupts.
In ucc_geth_stop(), it was clearing UCCE instead of UCCM.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
drivers/net/ucc_geth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 18b731b..e4736a3 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -2276,7 +2276,7 @@ static void ucc_geth_stop(struct ucc_geth_private *ugeth)
phy_stop(phydev);
/* Mask all interrupts */
- out_be32(ugeth->uccf->p_ucce, 0x00000000);
+ out_be32(ugeth->uccf->p_uccm, 0x00000000);
/* Clear all interrupts */
out_be32(ugeth->uccf->p_ucce, 0xffffffff);
--
1.5.0.2.260.g2eb065
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] QE Ethernet driver writes to wrong register to mask interrupts
2007-07-10 12:51 [PATCH] QE Ethernet driver writes to wrong register to mask interrupts Timur Tabi
@ 2007-07-10 12:59 ` Li Yang-r58472
2007-07-10 16:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Li Yang-r58472 @ 2007-07-10 12:59 UTC (permalink / raw)
To: Tabi Timur-B04825, jgarzik, netdev
> -----Original Message-----
> From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org] On
> Behalf Of Tabi Timur-B04825
> Sent: Tuesday, July 10, 2007 8:51 PM
> To: jgarzik@pobox.com; netdev@vger.kernel.org
> Cc: Tabi Timur-B04825
> Subject: [PATCH] QE Ethernet driver writes to wrong register to mask
interrupts
>
> The QE Ethernet driver was writing to the wrong register to mask
interrupts.
> In ucc_geth_stop(), it was clearing UCCE instead of UCCM.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Acked-by: Li Yang <leoli@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] QE Ethernet driver writes to wrong register to mask interrupts
2007-07-10 12:51 [PATCH] QE Ethernet driver writes to wrong register to mask interrupts Timur Tabi
2007-07-10 12:59 ` Li Yang-r58472
@ 2007-07-10 16:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-07-10 16:26 UTC (permalink / raw)
To: Timur Tabi; +Cc: netdev
Timur Tabi wrote:
> The QE Ethernet driver was writing to the wrong register to mask interrupts.
> In ucc_geth_stop(), it was clearing UCCE instead of UCCM.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> drivers/net/ucc_geth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-10 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-10 12:51 [PATCH] QE Ethernet driver writes to wrong register to mask interrupts Timur Tabi
2007-07-10 12:59 ` Li Yang-r58472
2007-07-10 16:26 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).