From: Jeff Garzik <jeff@garzik.org>
To: Philippe De Muyter <phdm@macqel.be>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] 7990 : Various fixes and cleanups
Date: Tue, 10 Jul 2007 12:38:45 -0400 [thread overview]
Message-ID: <4693B615.6010605@garzik.org> (raw)
In-Reply-To: <20070706095828.GA12270@muff.macqel.be>
Philippe De Muyter wrote:
> This patch
> - avoids 7990 blocking when no tx buffer is available,
[...]
> diff -r 6c0a10cc415a drivers/net/7990.c
> --- a/drivers/net/7990.c Thu Jul 5 16:10:16 2007 -0700
> +++ b/drivers/net/7990.c Fri Jul 6 11:27:20 2007 +0200
[...]
> @@ -541,9 +546,6 @@ int lance_start_xmit (struct sk_buff *sk
> static int outs;
> unsigned long flags;
>
> - if (!TX_BUFFS_AVAIL)
> - return -1;
> -
> netif_stop_queue (dev);
>
> skblen = skb->len;
> @@ -565,9 +567,11 @@ int lance_start_xmit (struct sk_buff *sk
> ib->btx_ring [entry].length = (-len) | 0xf000;
> ib->btx_ring [entry].misc = 0;
>
> - if (skb->len < ETH_ZLEN)
> - memset((void *)&ib->tx_buf[entry][0], 0, ETH_ZLEN);
> skb_copy_from_linear_data(skb, (void *)&ib->tx_buf[entry][0], skblen);
> + if (skblen < ETH_ZLEN)
> + memset((char *)&ib->tx_buf[entry][0] + skblen, 0, ETH_ZLEN - skblen);
> +
> + lp->stats.tx_bytes += skblen;
NAK
It "avoids" by removing an overrun check in hard_start_xmit that should
not be removed.
next prev parent reply other threads:[~2007-07-10 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 9:58 [PATCH] 7990 : Various fixes and cleanups Philippe De Muyter
2007-07-10 16:38 ` Jeff Garzik [this message]
2007-07-13 10:44 ` Philippe De Muyter
2007-07-13 18:57 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4693B615.6010605@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).