* [PATCH] atl1: remove write-only var in tx handler
@ 2007-07-06 15:05 Alexey Dobriyan
2007-07-06 15:28 ` Jay Cliburn
2007-07-10 16:42 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2007-07-06 15:05 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, jcliburn, csnook
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
drivers/net/atl1/atl1_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1/atl1_main.c
@@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter *adapter)
struct atl1_buffer *buffer_info;
u16 sw_tpd_next_to_clean;
u16 cmb_tpd_next_to_clean;
- u8 update = 0;
sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
cmb_tpd_next_to_clean = le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx);
while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
struct tx_packet_desc *tpd;
- update = 1;
+
tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
buffer_info = &tpd_ring->buffer_info[sw_tpd_next_to_clean];
if (buffer_info->dma) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] atl1: remove write-only var in tx handler
2007-07-06 15:05 [PATCH] atl1: remove write-only var in tx handler Alexey Dobriyan
@ 2007-07-06 15:28 ` Jay Cliburn
2007-07-10 16:42 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jay Cliburn @ 2007-07-06 15:28 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: jgarzik, netdev, csnook
On Fri, 6 Jul 2007 19:05:25 +0400
Alexey Dobriyan <adobriyan@sw.ru> wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> drivers/net/atl1/atl1_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter
> *adapter) struct atl1_buffer *buffer_info;
> u16 sw_tpd_next_to_clean;
> u16 cmb_tpd_next_to_clean;
> - u8 update = 0;
>
> sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
> cmb_tpd_next_to_clean =
> le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx);
> while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
> struct tx_packet_desc *tpd;
> - update = 1;
> +
> tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
> buffer_info =
> &tpd_ring->buffer_info[sw_tpd_next_to_clean]; if (buffer_info->dma) {
>
Acked-by: Jay Cliburn <jacliburn@bellsouth.net>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] atl1: remove write-only var in tx handler
2007-07-06 15:05 [PATCH] atl1: remove write-only var in tx handler Alexey Dobriyan
2007-07-06 15:28 ` Jay Cliburn
@ 2007-07-10 16:42 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-07-10 16:42 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: netdev, jcliburn, csnook
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> drivers/net/atl1/atl1_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-10 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-06 15:05 [PATCH] atl1: remove write-only var in tx handler Alexey Dobriyan
2007-07-06 15:28 ` Jay Cliburn
2007-07-10 16:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).