From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964F31A5B9 for ; Thu, 26 Oct 2023 18:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Ae94W2+r" Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [IPv6:2001:41d0:1004:224b::af]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2345DD49 for ; Thu, 26 Oct 2023 11:20:45 -0700 (PDT) Message-ID: <4693cb58-ab86-495f-838e-50464fe116ce@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698344440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zdfz9dbBUnxK7CCnvyJwACcXErsLKbZ8wsFVwYqLJ+s=; b=Ae94W2+rYlVe/tLX3osTwITgp/E85oylSGm3WLKBjIy+cJABM6qbc1hAHCoWdxogkATXXT RQjHUhX3swK6XyQlYQmcMHGjMOS/AJLtIgP2NbKFfsRX9b028H500PzfV+rFvjmrpKB6q/ Znw20+Ghv6azoOuevXL42O6pTSAAQeo= Date: Thu, 26 Oct 2023 19:20:33 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 2/2] selftests: bpf: crypto skcipher algo selftests Content-Language: en-US To: Daniel Borkmann , Vadim Fedorenko , Martin KaFai Lau , Andrii Nakryiko , Alexei Starovoitov , Mykola Lysenko Cc: bpf@vger.kernel.org, netdev@vger.kernel.org References: <20231026015938.276743-1-vadfed@meta.com> <20231026015938.276743-2-vadfed@meta.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 26/10/2023 15:02, Daniel Borkmann wrote: > On 10/26/23 3:59 AM, Vadim Fedorenko wrote: >> Add simple tc hook selftests to show the way to work with new crypto >> BPF API. Some weird structre and map are added to setup program to make >> verifier happy about dynptr initialization from memory. Simple AES-ECB >> algo is used to demonstrate encryption and decryption of fixed size >> buffers. >> >> Signed-off-by: Vadim Fedorenko >> --- >>   tools/testing/selftests/bpf/config            |   1 + >>   .../selftests/bpf/prog_tests/crypto_sanity.c  | 129 +++++++++++++++ >>   .../selftests/bpf/progs/crypto_common.h       |  98 +++++++++++ >>   .../selftests/bpf/progs/crypto_sanity.c       | 154 ++++++++++++++++++ >>   4 files changed, 382 insertions(+) >>   create mode 100644 >> tools/testing/selftests/bpf/prog_tests/crypto_sanity.c >>   create mode 100644 tools/testing/selftests/bpf/progs/crypto_common.h >>   create mode 100644 tools/testing/selftests/bpf/progs/crypto_sanity.c >> >> diff --git a/tools/testing/selftests/bpf/config >> b/tools/testing/selftests/bpf/config >> index 02dd4409200e..2a5d6339831b 100644 >> --- a/tools/testing/selftests/bpf/config >> +++ b/tools/testing/selftests/bpf/config >> @@ -14,6 +14,7 @@ CONFIG_CGROUP_BPF=y >>   CONFIG_CRYPTO_HMAC=y >>   CONFIG_CRYPTO_SHA256=y >>   CONFIG_CRYPTO_USER_API_HASH=y >> +CONFIG_CRYPTO_SKCIPHER=y >>   CONFIG_DEBUG_INFO=y >>   CONFIG_DEBUG_INFO_BTF=y >>   CONFIG_DEBUG_INFO_DWARF4=y > > Quick note: for upstream CI side, more config seems missing, see the GHA > failure: Thanks for the signal, Daniel. Looks like CONFIG_CRYPTO_ECB is missing. I'll adjust config for v2, but I'll wait a bit longer to get more feedback > https://github.com/kernel-patches/bpf/actions/runs/6654055344/job/18081734522 > > Notice: Success: 435/3403, Skipped: 32, Failed: 1 > Error: #64 crypto_sanity >   Error: #64 crypto_sanity >   test_crypto_sanity:PASS:skel open 0 nsec >   test_crypto_sanity:PASS:ip netns add crypto_sanity_ns 0 nsec >   test_crypto_sanity:PASS:ip -net crypto_sanity_ns -6 addr add > face::1/128 dev lo nodad 0 nsec >   test_crypto_sanity:PASS:ip -net crypto_sanity_ns link set dev lo up 0 > nsec >   test_crypto_sanity:PASS:crypto_sanity__load 0 nsec >   open_netns:PASS:malloc token 0 nsec >   open_netns:PASS:open /proc/self/ns/net 0 nsec >   open_netns:PASS:open netns fd 0 nsec >   open_netns:PASS:setns 0 nsec >   test_crypto_sanity:PASS:open_netns 0 nsec >   test_crypto_sanity:PASS:if_nametoindex lo 0 nsec >   test_crypto_sanity:PASS:crypto_sanity__attach 0 nsec >   test_crypto_sanity:PASS:skb_crypto_setup fd 0 nsec >   test_crypto_sanity:PASS:skb_crypto_setup 0 nsec >   test_crypto_sanity:PASS:skb_crypto_setup retval 0 nsec >   test_crypto_sanity:FAIL:skb_crypto_setup status unexpected error: -95 > (errno 2) >   libbpf: Kernel error message: Parent Qdisc doesn't exists >   close_netns:PASS:setns 0 nsec > Test Results: >              bpftool: PASS >  test_progs-no_alu32: FAIL (returned 1) >             shutdown: CLEAN > Error: Process completed with exit code 1.