netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Ben Greear <greearb@candelatech.com>
Subject: [VLAN]: Fix memset length
Date: Thu, 12 Jul 2007 20:16:39 +0200	[thread overview]
Message-ID: <46967007.1050200@trash.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]

Fix a bug in the patches I sent yesterday. Should apply cleanly with
or without the macvlan stuff.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 970 bytes --]

[VLAN]: Fix memset length

Fix sizeof(ETH_ALEN) Introduced by my rtnl_link patches.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 38080b6eda6e5a93a4bd11a5f4a4941d9558d816
tree 4d911975d4b420c372050056f949b3c36595596d
parent 553029f4dd24c41322c3e6cb31458e7e094d21ee
author Patrick McHardy <kaber@trash.net> Thu, 12 Jul 2007 20:15:00 +0200
committer Patrick McHardy <kaber@trash.net> Thu, 12 Jul 2007 20:15:00 +0200

 net/8021q/vlan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 39bdcc2..cda936b 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -377,7 +377,7 @@ void vlan_setup(struct net_device *new_dev)
 	new_dev->destructor = free_netdev;
 	new_dev->do_ioctl = vlan_dev_ioctl;
 
-	memset(new_dev->broadcast, 0, sizeof(ETH_ALEN));
+	memset(new_dev->broadcast, 0, ETH_ALEN);
 }
 
 static void vlan_transfer_operstate(const struct net_device *dev, struct net_device *vlandev)

             reply	other threads:[~2007-07-12 18:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12 18:16 Patrick McHardy [this message]
2007-07-15  1:56 ` [VLAN]: Fix memset length David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46967007.1050200@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).