netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] NET_CLS_RSVP6 should depend on IPV6
@ 2007-07-14 10:38 Gabriel C
  2007-07-14 15:36 ` Patrick McHardy
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel C @ 2007-07-14 10:38 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Alexey Kuznetsov, netdev

Hello,

cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
on IPV6.


Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>

---

net/sched/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index b466288..200976e 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -299,6 +299,7 @@ config NET_CLS_RSVP
 
 config NET_CLS_RSVP6
        tristate "IPv6 Resource Reservation Protocol (RSVP6)"
+       depends on IPV6
        select NET_CLS
        ---help---
          The Resource Reservation Protocol (RSVP) permits end systems to
@@ -306,7 +307,7 @@ config NET_CLS_RSVP6
          is important for real time data such as streaming sound or video.
 
          Say Y here if you want to be able to classify outgoing packets
based
-         on their RSVP requests and you are using the IPv6.
+         on their RSVP requests and you are using the IPv6 protocol.
 
          To compile this code as a module, choose M here: the
          module will be called cls_rsvp6.



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6
  2007-07-14 10:38 [PATCH] NET_CLS_RSVP6 should depend on IPV6 Gabriel C
@ 2007-07-14 15:36 ` Patrick McHardy
  2007-07-14 18:29   ` Gabriel C
  2007-07-14 20:04   ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Patrick McHardy @ 2007-07-14 15:36 UTC (permalink / raw)
  To: Gabriel C; +Cc: Linux Kernel Mailing List, Alexey Kuznetsov, netdev

Gabriel C wrote:
> cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
> on IPV6.


I can't see any functional dependency on IPv6, what exactly are you
refering to? People might want to use it on a bridge for example
without having IPv6 running locally.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6
  2007-07-14 15:36 ` Patrick McHardy
@ 2007-07-14 18:29   ` Gabriel C
  2007-07-14 20:04   ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: Gabriel C @ 2007-07-14 18:29 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: Linux Kernel Mailing List, Alexey Kuznetsov, netdev

Patrick McHardy wrote:
> Gabriel C wrote:
>   
>> cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
>> on IPV6.
>>     
>
>
> I can't see any functional dependency on IPv6, what exactly are you
> refering to? People might want to use it on a bridge for example
> without having IPv6 running locally.
>
>   

I didn't knew it can be used with bridges , in this case just ignore the
patch and sorry for the noise.


Regards,

Gabriel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] NET_CLS_RSVP6 should depend on IPV6
  2007-07-14 15:36 ` Patrick McHardy
  2007-07-14 18:29   ` Gabriel C
@ 2007-07-14 20:04   ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-07-14 20:04 UTC (permalink / raw)
  To: kaber; +Cc: nix.or.die, linux-kernel, kuznet, netdev

From: Patrick McHardy <kaber@trash.net>
Date: Sat, 14 Jul 2007 17:36:14 +0200

> Gabriel C wrote:
> > cls_rsvp6 only works with IPV6 enabled kernels and IMO it should depends
> > on IPV6.
> 
> 
> I can't see any functional dependency on IPv6, what exactly are you
> refering to? People might want to use it on a bridge for example
> without having IPv6 running locally.

That's my feeling as well.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-07-14 20:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-14 10:38 [PATCH] NET_CLS_RSVP6 should depend on IPV6 Gabriel C
2007-07-14 15:36 ` Patrick McHardy
2007-07-14 18:29   ` Gabriel C
2007-07-14 20:04   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).