From: Jeff Garzik <jeff@garzik.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
bryan.wu@analog.com, LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
Date: Sat, 14 Jul 2007 16:33:27 -0400 [thread overview]
Message-ID: <46993317.3070203@garzik.org> (raw)
In-Reply-To: <200707142217.36361.mb@bu3sch.de>
Michael Buesch wrote:
> Well, this bitfield _might_ be OK (although I don't like bitfields
> at all), but the above pointer casting stuff should really use
> leXX_to_cpu. It's so easy to use and it is easier to read and
> maintain the code afterwards.
> If the bitfield stays, a comment must be added.
Regardless of endian issues, the bitfield usage should go away.
Jeff
next prev parent reply other threads:[~2007-07-14 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 18:49 [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver Bryan Wu
2007-07-14 19:38 ` Michael Buesch
2007-07-14 19:49 ` Mike Frysinger
2007-07-14 20:17 ` Michael Buesch
2007-07-14 20:33 ` Jeff Garzik [this message]
2007-07-14 20:38 ` Mike Frysinger
2007-07-15 13:04 ` Dan Williams
2007-07-15 13:55 ` Bryan Wu
2007-07-15 9:16 ` Bryan Wu
2007-07-15 9:36 ` Michael Buesch
2007-07-15 9:52 ` Bryan Wu
2007-07-15 13:12 ` Dan Williams
2007-07-15 15:09 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46993317.3070203@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).