From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Ranko Zivojnovic <ranko@spidernet.net>, netdev@vger.kernel.org
Subject: Re: [NET]: gen_estimator deadlock fix
Date: Mon, 16 Jul 2007 15:03:32 +0200 [thread overview]
Message-ID: <469B6CA4.9030205@trash.net> (raw)
In-Reply-To: <20070716070032.GA1871@ff.dom.local>
Jarek Poplawski wrote:
> There is probably quite easy way to get rid of this one race only
> by e.g. replacing *bstats field with NULL in gen_kill_estimator,
> and check for this in est_timer just after taking a lock.
>
> The gain from an api change would be mainly faster gen_kill_
> and gen_replace_estimator. But, on the other hand, you have it
> almost done. Ranko, I think these changes need opinion of more
> maintainers as soon as possible - after all they could have some
> objections; IMHO at least: Jamal Hadi Salim, Thomas Graf (authors
> plus act_), Stephen Hemminger (sch_netem) and Jiri Benc
> (net/mac80211).
Frankly, all we need is a final patch.
next prev parent reply other threads:[~2007-07-16 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 13:41 [NET]: gen_estimator deadlock fix Ranko Zivojnovic
2007-07-12 7:37 ` Jarek Poplawski
2007-07-12 9:18 ` Ranko Zivojnovic
2007-07-12 9:40 ` Ranko Zivojnovic
2007-07-12 10:46 ` Jarek Poplawski
2007-07-12 11:47 ` Ranko Zivojnovic
2007-07-12 12:07 ` Patrick McHardy
2007-07-12 17:48 ` Ranko Zivojnovic
2007-07-13 12:17 ` Jarek Poplawski
2007-07-13 12:26 ` Ranko Zivojnovic
2007-07-13 13:42 ` Jarek Poplawski
2007-07-16 7:00 ` Jarek Poplawski
2007-07-16 13:03 ` Patrick McHardy [this message]
2007-07-16 17:45 ` Ranko Zivojnovic
2007-07-17 1:28 ` David Miller
2007-07-17 12:04 ` Jarek Poplawski
2007-07-17 12:01 ` Patrick McHardy
2007-07-17 12:28 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469B6CA4.9030205@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
--cc=ranko@spidernet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).