From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>,
Linus Torvalds <torvalds@linux-foundation.com>,
Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.com>,
lkml <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Chris Wright <chrisw@sous-sol.org>,
Ian Pratt <ian.pratt@xensource.com>,
Christian Limpach <Christian.Limpach@cl.cam.ac.uk>,
Jeff Garzik <jeff@garzik.org>,
Christoph Hellwig <hch@infradead.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Herbert Xu <herbert@gondor.apana.org.au>,
Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
netdev@vger.kernel.org
Subject: Re: [patch 37/44] xen: add virtual network device driver
Date: Tue, 17 Jul 2007 07:28:50 -0700 [thread overview]
Message-ID: <469CD222.1030202@goop.org> (raw)
In-Reply-To: <20070717094511.795beb69@oldman>
Stephen Hemminger wrote:
>> +struct netfront_info {
>> + struct list_head list;
>> + struct net_device *netdev;
>> +
>> + struct net_device_stats stats;
>>
>
> There is now a net_device_stats element inside net_device on
> 2.6.21 or later.
>
Ah, OK. Should I just do a s/stats/netdev->stats/? Is there a generic
get_stats routine as well?
>> +
>> + struct xen_netif_tx_front_ring tx;
>> + struct xen_netif_rx_front_ring rx;
>> +
>> + spinlock_t tx_lock;
>> + spinlock_t rx_lock;
>>
>
> It might be a performance advantage to reorder/align these
> structure elements to put transmit hot elements together, and
> put tx and rx on different cache lines?
>
Oh, right. I'd been meaning to look at that layout more closely.
Thanks,
J
next prev parent reply other threads:[~2007-07-17 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070716231536.937393000@xensource.com>
2007-07-16 23:16 ` [patch 37/44] xen: add virtual network device driver Jeremy Fitzhardinge
[not found] ` <20070716232916.472694000@xensource.com>
2007-07-17 1:07 ` Jeff Garzik
2007-07-17 8:45 ` Stephen Hemminger
2007-07-17 14:28 ` Jeremy Fitzhardinge [this message]
2007-07-17 23:45 ` Rusty Russell
2007-07-18 0:40 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469CD222.1030202@goop.org \
--to=jeremy@goop.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.com \
--cc=chrisw@sous-sol.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=ian.pratt@xensource.com \
--cc=jeff@garzik.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
--cc=torvalds@linux-foundation.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).