From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: crquan@gmail.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru,
pekkas@netcore.fi, jmorris@namei.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
Date: Wed, 18 Jul 2007 12:10:44 +0200 [thread overview]
Message-ID: <469DE724.2020000@trash.net> (raw)
In-Reply-To: <20070718.030440.124084796.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Wed, 18 Jul 2007 12:01:38 +0200
>
>
>>rae l wrote:
>>
>>>All in one word, I don't think the single file dev_mcast.c is needed
>>>anymore.
>>
>>Agreed. But dev.c is growing larger and larger, maybe dev_addr.c?
>>Or dev_config.c, with some of the other device configuration functions?
>
>
> I don't know, a sizable dev.c is inevitable, allows better refactoring
> and consolidation. And the be honest you're going to have to likely
> touch things in dev.c whenever you make changes to dev_addr.c or
> whatever you want to name it. :-)
You're probably right. Killing dev_mcast.c makes sense to me though.
next prev parent reply other threads:[~2007-07-18 10:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11846606051099-git-send-email-crquan@gmail.com>
2007-07-18 2:41 ` [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c Denis Cheng
2007-07-18 2:41 ` [PATCH 2/3] [net/core] merge dev_unicast_discard and dev_mc_discard into one Denis Cheng
2007-07-18 2:41 ` [PATCH 3/3] [net/core] move __dev_addr_discard adjacent to dev_addr_discard for readability Denis Cheng
2007-07-18 9:13 ` David Miller
2007-07-18 9:12 ` [PATCH 2/3] [net/core] merge dev_unicast_discard and dev_mc_discard into one David Miller
2007-07-18 9:11 ` [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c David Miller
2007-07-18 9:59 ` rae l
2007-07-18 10:01 ` Patrick McHardy
2007-07-18 10:04 ` David Miller
2007-07-18 10:10 ` Patrick McHardy [this message]
2007-07-18 10:03 ` David Miller
2007-07-18 11:30 ` [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c Denis Cheng
2007-07-18 11:30 ` [PATCH 2/2] net/core: some functions' definition order adjustment for readability Denis Cheng
2007-07-18 12:39 ` Patrick McHardy
2007-07-18 14:31 ` rae l
2007-07-20 1:51 ` [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c rae l
2007-07-20 3:04 ` David Miller
2007-07-20 3:22 ` rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469DE724.2020000@trash.net \
--to=kaber@trash.net \
--cc=crquan@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).