From: Jeff Garzik <jeff@garzik.org>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: NetDev <netdev@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
Mitch Williams <mitch.a.williams@intel.com>
Subject: Re: ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express)
Date: Wed, 18 Jul 2007 23:00:39 -0400 [thread overview]
Message-ID: <469ED3D7.6040905@garzik.org> (raw)
In-Reply-To: <46980ADA.5050104@intel.com>
Kok, Auke wrote:
>
>
> All,
>
> We are pleased to announce a new Gigabit Ethernet product and its driver
> to the
> linux community. This product is the Intel(R) 82575 Gigabit Ethernet
> adapter
> family. Physical adapters will be available to the public soon. These
> adapters
> come in 2- and 4-port versions (copper PHY) currently. Other variants
> will be
> available later.
>
> The 82575 chipset supports significantly different features that warrant
> a new
> driver. The descriptor format is (just like the ixgbe driver) different.
> The
> device can use multiple MSI-X vectors and multiple queues for both send and
> receive. This allows us to optimize some of the driver code specifically
> as well
> compared to the e1000-supported devices.
>
> This driver was forked from e1000 several months ago and extensively
> reworked
> and cleaned up since. The driver was also tested on several platforms in
> our
> validation labs.
>
> Allthough some of the codebase is currently shared with the e1000 driver
> (this
> igb driver has a copy of that code where needed), we realize that many
> of the
> changes that we are discussing for e1000 (the pci-express adapters that
> e1000
> supports particularly) will also apply to this driver. However, since
> this is a
> completely new driver that is relatively free of all old NIC support, we
> feel
> that it is currently the right time to post this driver.
>
> Unfortunately, the patch to insert this driver is too large to send to
> netdev. I
> have therefore posted the patch on http:
>
> http://foo-projects.org/~sofar/igb.patch [558K]
> http://foo-projects.org/~sofar/igb.patch.bz2 [98K]
Just took a look at this.
This has the same problem as in the other thread -- huge internal API --
except this time, the problem is emphasized by the fact that the
majority of the API hooks only have a single user, making each hook and
API entry point demonstrably useless overhead.
Please remove the useless internal API and resubmit.
PLEASE take a look at how bnx2 and tg3 are structured.
Jeff
next prev parent reply other threads:[~2007-07-19 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 23:29 ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express) Kok, Auke
2007-07-19 3:00 ` Jeff Garzik [this message]
2007-07-19 23:52 ` Kok, Auke
2007-07-20 7:33 ` Christoph Hellwig
2007-07-20 8:23 ` Stefan Rompf
2007-07-20 11:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469ED3D7.6040905@garzik.org \
--to=jeff@garzik.org \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=john.ronciak@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).