* [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]
@ 2007-07-19 4:55 Steven J. Hill
2007-07-19 14:15 ` Dale Farnsworth
0 siblings, 1 reply; 2+ messages in thread
From: Steven J. Hill @ 2007-07-19 4:55 UTC (permalink / raw)
To: netdev
[-- Attachment #1.1: Type: text/plain, Size: 129 bytes --]
Fix the TX bytes statistics counter to, um, actually count.
Signed-off-by: Steven J. Hill <sjhill1@rockwellcollins.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 06-mv643xx-fix-tx-statistics.patch --]
[-- Type: text/x-patch; name="06-mv643xx-fix-tx-statistics.patch", Size: 396 bytes --]
--- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.000000000 -0500
+++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 21:44:07.000000000 -0500
@@ -1506,7 +1511,7 @@
spin_lock_irqsave(&mp->lock, flags);
eth_tx_submit_descs_for_skb(mp, skb);
- stats->tx_bytes = skb->len;
+ stats->tx_bytes += skb->len;
stats->tx_packets++;
dev->trans_start = jiffies;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]
2007-07-19 4:55 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8] Steven J. Hill
@ 2007-07-19 14:15 ` Dale Farnsworth
0 siblings, 0 replies; 2+ messages in thread
From: Dale Farnsworth @ 2007-07-19 14:15 UTC (permalink / raw)
To: Steven J. Hill; +Cc: netdev
On Thu, Jul 19, 2007 at 04:55:36AM +0000, Steven J. Hill wrote:
> Fix the TX bytes statistics counter to, um, actually count.
>
> Signed-off-by: Steven J. Hill <sjhill1@rockwellcollins.com>
> ---
> --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.000000000 -0500
> +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 21:44:07.000000000 -0500
> @@ -1506,7 +1511,7 @@
> spin_lock_irqsave(&mp->lock, flags);
>
> eth_tx_submit_descs_for_skb(mp, skb);
> - stats->tx_bytes = skb->len;
> + stats->tx_bytes += skb->len;
> stats->tx_packets++;
> dev->trans_start = jiffies;
>
Good fix, thanks. Please resubmit per the guidelines in
Documentation/SubmittingPatches.
-Dale
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-19 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-19 4:55 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8] Steven J. Hill
2007-07-19 14:15 ` Dale Farnsworth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).