From: Ben Greear <greearb@candelatech.com>
To: andrei radulescu-banu <iubica2@yahoo.com>
Cc: Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Krzysztof Halasa <khc@pm.waw.pl>,
linux-kernel@vger.kernel.org,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: Linux, tcpdump and vlan
Date: Thu, 19 Jul 2007 09:47:24 -0700 [thread overview]
Message-ID: <469F959C.4090003@candelatech.com> (raw)
In-Reply-To: <123837.78916.qm@web56604.mail.re3.yahoo.com>
andrei radulescu-banu wrote:
>> [Ben] I think a better method would be to allow disabling VLAN HW accel for a NIC with ethtool.
>>
>
> This requires changes to ethtool and e1000 driver, +other drivers. It is a handy thing to have. I don't view it as a solution to tcpdump - or to the vlan bridging problem. One concern: if we're switching hw accel mode on the fly, we need to carefully protect tx frames that are just about going out and have already been set up for the opposite mode.
>
I think it would be valid to let a few packets slip through on the old
behaviour during changeover..or perhaps to drop them
entirely if that is required.
Turning off vlan hw-accel when the nic goes promisc is also going to
require driver changes, I believe, so
either way you have to do that work.
If tcpdump and/or bridging needs to disable the hw-accel, then it can
explicitly do so by some API. That is better than overloading
the promisc flag in my opinion. This is especially true since promisc
is not easily readable by user-space and things like tcpdump
cannot have full control of promisc (if a mac-vlan has the NIC in
promisc mode, for instance, then tcpdump can never disable it.)
> Any comments on what is the expected behavior of 'tcpdump -i eth0.2' vs. 'tcpdump -i eth0'?
>
I would expect that you see tags with -i eth0, but not with -i eth0.2
That is the way it currently works with non-hw-accell VLANs (or it was
the last I checked).
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2007-07-19 16:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 15:47 Linux, tcpdump and vlan andrei radulescu-banu
2007-07-19 16:21 ` Stephen Hemminger
2007-07-19 16:33 ` Patrick McHardy
2007-07-19 16:47 ` Ben Greear [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-19 21:38 andrei radulescu-banu
2007-07-19 23:38 ` Ben Greear
2007-07-20 20:19 ` Krzysztof Halasa
2007-07-19 18:20 andrei radulescu-banu
2007-07-19 19:28 ` Stephen Hemminger
2007-07-19 17:46 andrei radulescu-banu
2007-07-19 16:02 andrei radulescu-banu
2007-07-20 19:58 ` Krzysztof Halasa
2007-07-20 20:34 ` Ben Greear
2007-07-21 11:32 ` Krzysztof Halasa
2007-07-21 17:57 ` Ben Greear
2007-07-21 21:15 ` Krzysztof Halasa
[not found] <878246.51044.qm@web56608.mail.re3.yahoo.com>
2007-07-18 22:57 ` Patrick McHardy
2007-07-18 23:22 ` Ben Greear
2007-07-18 23:34 ` Patrick McHardy
2007-07-19 0:01 ` Ben Greear
2007-07-19 0:19 ` Patrick McHardy
2007-07-19 13:28 ` Krzysztof Halasa
2007-07-19 13:41 ` Stephen Hemminger
2007-07-19 14:00 ` Patrick McHardy
2007-07-19 14:23 ` Krzysztof Halasa
2007-07-19 15:00 ` Stephen Hemminger
2007-07-19 15:45 ` Krzysztof Halasa
2007-07-19 15:20 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469F959C.4090003@candelatech.com \
--to=greearb@candelatech.com \
--cc=iubica2@yahoo.com \
--cc=kaber@trash.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).