From: Simon Arlott <simon@fire.lp0.eu>
To: Patrick McHardy <kaber@trash.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add"
Date: Thu, 19 Jul 2007 19:29:51 +0100 [thread overview]
Message-ID: <469FAD9F.8050903@simon.arlott.org.uk> (raw)
In-Reply-To: <469B6C3D.3070807@trash.net>
[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]
On 16/07/07 14:01, Patrick McHardy wrote:
> Simon Arlott wrote:
>>>>>Changing an existing route:
>>>>># ip -6 r show 2002::/16
>>>>>2002::/16 dev sit0 metric 1024 expires 4482618sec mtu 1480 advmss 7140
>>>>>hoplimit 4294967295
>>>>># ip -6 r change 2002::/16 dev sit0 mtu 1280
>>>>>RTNETLINK answers: File exists
> The code looks like it would support it properly. Please add a
> few printks to inet6_rtm_newaddr to find out what goes wrong.
Erm. It's routing configuration that's broken not address configuration
(ip doesn't even . Looking at route.c through to ip6_fib.c, it doesn't
support replacing routes at all.
$ grep NLM_F_ ipv4/fib_*.c ipv4/route.c ipv6/fib6_* ipv6/ip6_fib.c
ipv6/route.c
ipv4/fib_frontend.c: cfg->fc_nlflags = NLM_F_CREATE;
ipv4/fib_frontend.c: .fc_nlflags = NLM_F_CREATE | NLM_F_APPEND,
ipv4/fib_hash.c: if (cfg->fc_nlflags & NLM_F_EXCL)
ipv4/fib_hash.c: if (cfg->fc_nlflags & NLM_F_REPLACE) {
ipv4/fib_hash.c: &cfg->fc_nlinfo,
NLM_F_REPLACE);
ipv4/fib_hash.c: if (!(cfg->fc_nlflags & NLM_F_APPEND))
ipv4/fib_hash.c: if (!(cfg->fc_nlflags & NLM_F_CREATE))
ipv4/fib_hash.c: NLM_F_MULTI) <
0) {
ipv4/fib_trie.c: if (cfg->fc_nlflags & NLM_F_EXCL)
ipv4/fib_trie.c: if (cfg->fc_nlflags & NLM_F_REPLACE) {
ipv4/fib_trie.c: tb->tb_id,
&cfg->fc_nlinfo, NLM_F_REPLACE);
ipv4/fib_trie.c: if (!(cfg->fc_nlflags & NLM_F_APPEND))
ipv4/fib_trie.c: if (!(cfg->fc_nlflags & NLM_F_CREATE))
ipv4/route.c: 1, NLM_F_MULTI) <= 0) {
ipv6/route.c: prefix, NLM_F_MULTI);
--
Simon Arlott
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3623 bytes --]
prev parent reply other threads:[~2007-07-19 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-8755-10286@http.bugzilla.kernel.org/>
2007-07-15 4:47 ` [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add" Andrew Morton
2007-07-15 15:07 ` Patrick McHardy
2007-07-15 18:49 ` Simon Arlott
2007-07-16 13:01 ` Patrick McHardy
2007-07-16 18:05 ` Simon Arlott
2007-07-19 18:29 ` Simon Arlott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469FAD9F.8050903@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).