From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF196C35E0E for ; Tue, 25 Feb 2020 21:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C44A21D7E for ; Tue, 25 Feb 2020 21:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726764AbgBYVPr (ORCPT ); Tue, 25 Feb 2020 16:15:47 -0500 Received: from mga11.intel.com ([192.55.52.93]:11735 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgBYVPr (ORCPT ); Tue, 25 Feb 2020 16:15:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 13:15:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,485,1574150400"; d="asc'?scan'208";a="230247807" Received: from unknown (HELO jtkirshe-desk1.jf.intel.com) ([134.134.177.86]) by fmsmga007.fm.intel.com with ESMTP; 25 Feb 2020 13:15:46 -0800 Message-ID: <469b51add666cf3df7381b6409a3972c70024c12.camel@intel.com> Subject: Re: [patch net-next] iavf: use tc_cls_can_offload_basic() instead of chain check From: Jeff Kirsher Reply-To: jeffrey.t.kirsher@intel.com To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, intel-wired-lan@lists.osuosl.org Date: Tue, 25 Feb 2020 13:15:46 -0800 In-Reply-To: <20200225121023.6011-1-jiri@resnulli.us> References: <20200225121023.6011-1-jiri@resnulli.us> Organization: Intel Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-nElXtqeOP+3OIyzJeE4R" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-nElXtqeOP+3OIyzJeE4R Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-02-25 at 13:10 +0100, Jiri Pirko wrote: > From: Jiri Pirko >=20 > Looks like the iavf code actually experienced a race condition, when > a > developer took code before the check for chain 0 was put to helper. > So use tc_cls_can_offload_basic() helper instead of direct check and > move the check to _cb() so this is similar to i40e code. >=20 > Signed-off-by: Jiri Pirko Acked-by: Jeff Kirsher Go ahead and pick this up Dave, thanks! > --- > This was originally part of "net: allow user specify TC filter HW > stats type" > patchset, but it is no longer related after the requested changes. > Sending separatelly. > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) --=-nElXtqeOP+3OIyzJeE4R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAl5VjoIACgkQ5W/vlVpL 7c6RkQ//YHqG2qXg2A3snvt2Uvn0PKS19+SnrLnlAmKcPMj/Mi0Tn4yoi2kF6fs7 h3TWd2Po7mAhE08U/YsSRsURpP9rM+NYBiJlzFQShsZbZ2N08gWPAZgo9PIkflrS PYM7FwQJE2tmaaGtgPqS4/o0YT7sftUScjIeyGloP78/PALGZZW8PhDsq+KrQooi XEOHffczQ75VHRXvIy6FsrCBDvv1kQGWCexBJktCBzPtxDQBCwu1Vl+EoEny7fi5 ei7lG9e18MmwdTt5JpuigMuCO4s4g8iaWwZKubStd03fy006wTzwOqto1d9QBC41 IYOXzqWe0MN7t7JUMuFCYLv4Y0PWAAQknxq4QhS42QXJ+XPLz/TbqKtI6biiqFVr lh/rufPYbNb9qPUFMooTArUdFNCDX43ttTOQdSM0xhMsGtNnZ0o4gsxp/cVzW6dD lB+fp0tYBi6SWPoQ4P3+buew7AeYtpsbqpiwRGmrFQ3/Z80DGxqI/9RzTLUgq2g3 UN2J3LQp3Yfte8gZqhCNPyy9LFU4EhxeFbvQ+SDQXFl8YGg7EhfgPDlEpPT4x2o6 yLweY9wOgkcItgjqZb49cuOCLlEfz31LNg5QlMBmmaQd4wFgBgcPsX0rHOl/Rgdc Fnr95EEzwT6qd2m2t9G+8aEZ60S3E7/AkqB+//dAxmttMTpwQdw= =rPmc -----END PGP SIGNATURE----- --=-nElXtqeOP+3OIyzJeE4R--