From: Martin KaFai Lau <martin.lau@linux.dev>
To: Wang Yufen <wangyufen@huawei.com>, Lina Wang <lina.wang@mediatek.com>
Cc: bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, lina.wang@mediatek.com,
deso@posteo.net, netdev@vger.kernel.org
Subject: Re: [net 1/2] selftests/net: fix opening object file failed
Date: Wed, 12 Oct 2022 18:51:55 -0700 [thread overview]
Message-ID: <469d28c0-8156-37ad-d0d9-c11608ca7e07@linux.dev> (raw)
In-Reply-To: <1665482267-30706-2-git-send-email-wangyufen@huawei.com>
On 10/11/22 2:57 AM, Wang Yufen wrote:
> The program file used in the udpgro_frglist testcase is "../bpf/nat6to4.o",
> but the actual nat6to4.o file is in "bpf/" not "../bpf".
> The following error occurs:
> Error opening object ../bpf/nat6to4.o: No such file or directory
hmm... so it sounds like the test never works...
The test seems like mostly exercising the tc-bpf? It makes sense to move it to
the selftests/bpf. or staying in net is also fine for now and only need to fix
up the path here.
However, if moving to selftests/bpf, I don't think it is a good idea to only
move the bpf prog but not moving the actual test program (the script here) such
that the bpf CI can continuously testing it. Otherwise, it will just drift and
rot slowly like patch 2.
Also, if you prefer to move it to selftests/bpf, the bpf prog cannot be moved in
the current form. eg. There is some convention on the SEC name in the
selftests/bpf/progs. Also, the testing script needs to be adapted to the
selftests/bpf/test_progs infra.
next prev parent reply other threads:[~2022-10-13 1:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 9:57 [net 0/2] some fixes for selftest/net Wang Yufen
2022-10-11 9:57 ` [net 1/2] selftests/net: fix opening object file failed Wang Yufen
2022-10-13 1:51 ` Martin KaFai Lau [this message]
2022-10-18 2:57 ` wangyufen
2022-10-18 9:50 ` wangyufen
2022-10-18 16:26 ` Alexei Starovoitov
2022-10-18 18:00 ` Jakub Kicinski
2022-10-19 1:30 ` Martin KaFai Lau
2022-10-19 1:53 ` Jakub Kicinski
2022-10-11 9:57 ` [net 2/2] selftests/net: fix missing xdp_dummy Wang Yufen
2022-10-11 16:27 ` Daniel Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469d28c0-8156-37ad-d0d9-c11608ca7e07@linux.dev \
--to=martin.lau@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=deso@posteo.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lina.wang@mediatek.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).