From: "Steven J. Hill" <sjhill@realitydiluted.com>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]
Date: Thu, 19 Jul 2007 21:10:26 -0500 [thread overview]
Message-ID: <46A01992.1060907@realitydiluted.com> (raw)
In-Reply-To: <20070719142159.GF12892@xyzzy.farnsworth.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dale Farnsworth wrote:
>
> You have replaced the use of the global PHY spinlock with a per-port spinlock.
> However, the SMI register is shared by all ports. The global lock is
> needed to prevent simultaneous updates of the register by drivers for
> multiple ports.
>
> NAK
>
Are you sure? Notice that a majority of the spinlocks were changed to disable
IRQs. Secondly, the lowest level mv_read/mv_write functions have to acquire
the big mv64x60_lock before they can read or write registers. I see the PHY
spinlock as being an additional and unnecessary lock to contend with. Am I
make an improper assumption?
- -Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGoBmSgyK5H2Ic36cRAj8JAKCfmg/T2FgOdYZ5YfnXJsiyn3RkaQCfadSk
GS8ICyW0+qNRHr5QqnY0PUQ=
=nvSB
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-07-20 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 4:56 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8] Steven J. Hill
2007-07-19 14:21 ` Dale Farnsworth
2007-07-20 2:10 ` Steven J. Hill [this message]
2007-07-20 3:40 ` Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A01992.1060907@realitydiluted.com \
--to=sjhill@realitydiluted.com \
--cc=dale@farnsworth.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).