From: Divy Le Ray <divy@chelsio.com>
To: Denis Cheng <crquan@gmail.com>
Cc: linux-bugs@chelsio.com, Andrew Morton <akpm@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, cr_quan@163.com
Subject: Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization
Date: Fri, 20 Jul 2007 18:22:42 -0700 [thread overview]
Message-ID: <46A15FE2.7030108@chelsio.com> (raw)
In-Reply-To: <11847434891556-git-send-email-crquan@gmail.com>
Denis Cheng wrote:
> Cc: linux-bugs@chelsio.com
> Signed-off-by: Denis Cheng <crquan@gmail.com>
>
Acked-by: Divy Le Ray <divy@chelsio.com>
> ---
> drivers/net/cxgb3/cxgb3_main.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index 6fd1e52..45711f9 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -754,7 +754,7 @@ static int upgrade_fw(struct adapter *adap)
> */
> static int cxgb_up(struct adapter *adap)
> {
> - int err = 0;
> + int err;
>
> if (!(adap->flags & FULL_INIT_DONE)) {
> err = t3_check_fw_version(adap);
> @@ -861,7 +861,7 @@ static int offload_open(struct net_device *dev)
> struct adapter *adapter = dev->priv;
> struct t3cdev *tdev = T3CDEV(dev);
> int adap_up = adapter->open_device_map & PORT_MASK;
> - int err = 0;
> + int err;
>
> if (test_and_set_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map))
> return 0;
> @@ -1502,7 +1502,7 @@ static int set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
> u8 * data)
> {
> u8 *buf;
> - int err = 0;
> + int err;
> u32 aligned_offset, aligned_len, *p;
> struct adapter *adapter = dev->priv;
>
>
next prev parent reply other threads:[~2007-07-21 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 7:24 [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization Denis Cheng
2007-07-21 1:22 ` Divy Le Ray [this message]
2007-07-30 20:04 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A15FE2.7030108@chelsio.com \
--to=divy@chelsio.com \
--cc=akpm@linux-foundation.org \
--cc=cr_quan@163.com \
--cc=crquan@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-bugs@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).