From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
rusty@rustcorp.com.au, jgarzik@pobox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.
Date: Sat, 21 Jul 2007 07:46:39 +0200 [thread overview]
Message-ID: <46A19DBF.6030902@trash.net> (raw)
In-Reply-To: <20070720.223129.59470764.davem@davemloft.net>
David Miller wrote:
[ huge patch, not looked at it :) ]
> One area for discussion is what to do about rtnetlink, it allows
> setting the dev->napi.weight, but we need to extend it so it can
> do something sane in multi-napi-per-netdev situations.
I believe the compat attribute should work fine. One thing thing
that is not explicitly supported as datatype, but works fine, is
lists of attributes (using nla_for_each_attr), which looks like a
good match for this case. But I think its questionable whether we
should put any effort in NAPI rtnetlink support. It seems to driver
specific for rtnetlink to me, and I'm not aware of any user of this.
Ethtool might have its own compatibility issues, I'm not sure, but
I don't think it would hurt to simply remove it from rtnetlink.
next prev parent reply other threads:[~2007-07-21 5:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 5:31 [PATCH]: Resurrect napi_poll patch David Miller
2007-07-21 5:46 ` Patrick McHardy [this message]
2007-07-21 6:00 ` David Miller
2007-07-21 7:14 ` Rusty Russell
2007-07-21 7:42 ` David Miller
2007-07-21 8:00 ` Rusty Russell
2007-07-21 18:54 ` David Miller
2007-07-21 23:10 ` Rusty Russell
2007-07-22 1:59 ` David Miller
2007-07-22 2:39 ` Rusty Russell
2007-07-22 3:54 ` David Miller
2007-07-22 7:18 ` David Miller
2007-07-22 7:36 ` David Miller
2007-07-22 7:51 ` Rusty Russell
2007-07-22 8:24 ` David Miller
2007-07-21 13:26 ` Andi Kleen
2007-07-23 9:58 ` Stephen Hemminger
2007-07-23 17:06 ` Andi Kleen
2007-07-23 21:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A19DBF.6030902@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).