netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: patric <pakar@imperialnet.org>
To: netdev <netdev@vger.kernel.org>
Subject: Re: tg3 issues
Date: Sun, 22 Jul 2007 13:43:24 +0200	[thread overview]
Message-ID: <46A342DC.1030305@imperialnet.org> (raw)
In-Reply-To: <46A113BA.7050805@imperialnet.org>

patric wrote:

> Hi,
>
> Think i got something working for me at least, and the fix is quite 
> minimal and only downside that i could see from it was that you might 
> get a small delay when bringing up the interface, but that's probably 
> better than getting a non-functional interface that reports that it's up.
>
> The fix seems to be quite simple with just a random sleep at the end 
> of  "tg3_setup_fiber_by_hand():"
>
>                tw32_f(MAC_MODE, tp->mac_mode);
>                udelay(40);
>        }
>
> out:
>        udelay( net_random() % 400 );
>        return current_link_up;
> }
>
> Not sure that this is a good fix or if it might break on other 
> systems, but maybe you could have a quick look at that?
>
> Regards,
> Patric
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Last update on this.

"udelay( 100 + net_random % 300 )" seems to work much better and i have 
not had a single problem getting the link up within 10 seconds of a cold 
or warm-boot, and most often the link comes up directly without any sort 
of delay instead like before when it could hang for 30 seconds before 
getting a link, if you even got a link.

/Patric


  reply	other threads:[~2007-07-22 11:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <469E78A2.80904@imperialnet.org>
2007-07-19 11:19 ` tg3 issues pradeep singh
2007-07-19 11:37   ` Neil Horman
2007-07-19 13:24     ` patric
2007-07-19 17:34       ` Michael Chan
2007-07-20 16:59         ` patric
2007-07-20 19:34           ` Michael Chan
2007-07-20 19:57             ` patric
2007-07-22 11:43               ` patric [this message]
2007-07-23 21:34                 ` Michael Chan
2007-07-24  7:33                   ` patric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A342DC.1030305@imperialnet.org \
    --to=pakar@imperialnet.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).