From: Patrick McHardy <kaber@trash.net>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: davem@davemloft.net, rdreier@cisco.com, johnpol@2ka.mipt.ru,
Robert.Olsson@data.slu.se, peter.p.waskiewicz.jr@intel.com,
herbert@gondor.apana.org.au, gaagaan@gmail.com,
kumarkr@linux.ibm.com, xma@us.ibm.com, rick.jones2@hp.com,
mcarlson@broadcom.com, netdev@vger.kernel.org, jagana@us.ibm.com,
general@lists.openfabrics.org, mchan@broadcom.com, tgraf@suug.ch,
jeff@garzik.org, hadi@cyberus.ca, sri@us.ibm.com
Subject: Re: [PATCH 06/12 -Rev2] rtnetlink changes.
Date: Sun, 22 Jul 2007 19:10:37 +0200 [thread overview]
Message-ID: <46A38F8D.6080109@trash.net> (raw)
In-Reply-To: <20070722090553.7787.28728.sendpatchset@K50wks273871wss.in.ibm.com>
Krishna Kumar wrote:
> diff -ruNp org/include/linux/if_link.h rev2/include/linux/if_link.h
> --- org/include/linux/if_link.h 2007-07-20 16:33:35.000000000 +0530
> +++ rev2/include/linux/if_link.h 2007-07-20 16:35:08.000000000 +0530
> @@ -78,6 +78,8 @@ enum
> IFLA_LINKMODE,
> IFLA_LINKINFO,
> #define IFLA_LINKINFO IFLA_LINKINFO
> + IFLA_TXBTHSKB, /* Driver support for Batch'd skbs */
> +#define IFLA_TXBTHSKB IFLA_TXBTHSKB
Ughh what a name :) I prefer pronouncable names since they are
much easier to remember and don't need comments explaining
what they mean.
But I actually think offering just an ethtool interface would
be better, at least for now.
next prev parent reply other threads:[~2007-07-22 17:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 9:04 [PATCH 00/12 -Rev2] Implement batching skb API Krishna Kumar
2007-07-22 9:05 ` [ofa-general] [PATCH 01/12 -Rev2] HOWTO documentation for Batching SKB Krishna Kumar
2007-07-22 9:05 ` [PATCH 02/12 -Rev2] Changes to netdevice.h Krishna Kumar
2007-07-22 17:06 ` [ofa-general] " Patrick McHardy
2007-07-23 2:57 ` Krishna Kumar2
2007-07-22 9:05 ` [ofa-general] [PATCH 03/12 -Rev2] dev.c changes Krishna Kumar
2007-07-23 10:44 ` [ofa-general] " Evgeniy Polyakov
2007-07-23 11:17 ` Krishna Kumar2
2007-07-22 9:05 ` [ofa-general] [PATCH 04/12 -Rev2] Ethtool changes Krishna Kumar
2007-07-22 9:05 ` [ofa-general] [PATCH 05/12 -Rev2] sysfs changes Krishna Kumar
2007-07-22 9:05 ` [ofa-general] [PATCH 06/12 -Rev2] rtnetlink changes Krishna Kumar
2007-07-22 17:10 ` Patrick McHardy [this message]
2007-07-23 2:54 ` [ofa-general] " Krishna Kumar2
2007-07-22 9:06 ` [ofa-general] [PATCH 07/12 -Rev2] Change qdisc_run & qdisc_restart API, callers Krishna Kumar
2007-07-22 9:06 ` [ofa-general] [PATCH 08/12 -Rev2] IPoIB include file changes Krishna Kumar
2007-07-22 9:06 ` [ofa-general] [PATCH 09/12 -Rev2] IPoIB verbs changes Krishna Kumar
2007-07-22 9:06 ` [ofa-general] [PATCH 10/12 -Rev2] IPoIB multicast, CM changes Krishna Kumar
2007-07-22 9:06 ` [ofa-general] [PATCH 11/12 -Rev2] IPoIB xmit API addition Krishna Kumar
2007-07-22 9:41 ` Michael S. Tsirkin
2007-07-23 2:53 ` [ofa-general] " Krishna Kumar2
2007-07-23 10:48 ` Evgeniy Polyakov
2007-07-23 11:17 ` Krishna Kumar2
2007-07-22 9:06 ` [ofa-general] [PATCH 12/12 -Rev2] IPoIB xmit internals changes (ipoib_ib.c) Krishna Kumar
2007-07-23 9:53 ` [PATCH 00/12 -Rev2] Implement batching skb API Krishna Kumar2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A38F8D.6080109@trash.net \
--to=kaber@trash.net \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=gaagaan@gmail.com \
--cc=general@lists.openfabrics.org \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=jagana@us.ibm.com \
--cc=jeff@garzik.org \
--cc=johnpol@2ka.mipt.ru \
--cc=krkumar2@in.ibm.com \
--cc=kumarkr@linux.ibm.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rdreier@cisco.com \
--cc=rick.jones2@hp.com \
--cc=sri@us.ibm.com \
--cc=tgraf@suug.ch \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).