* [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c
@ 2007-07-23 8:05 Micah Gruber
2007-07-24 12:57 ` Petko Manolov
2007-07-30 19:45 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Micah Gruber @ 2007-07-23 8:05 UTC (permalink / raw)
To: petkan, linux-kernel, netdev, jgarzik
This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing
after the null check.
Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
---
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -768,11 +768,13 @@
static void write_bulk_callback(struct urb *urb)
{
pegasus_t *pegasus = urb->context;
- struct net_device *net = pegasus->net;
+ struct net_device *net;
if (!pegasus)
return;
+ net = pegasus->net;
+
if (!netif_device_present(net) || !netif_running(net))
return;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c
2007-07-23 8:05 [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c Micah Gruber
@ 2007-07-24 12:57 ` Petko Manolov
2007-07-30 19:45 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Petko Manolov @ 2007-07-24 12:57 UTC (permalink / raw)
To: Micah Gruber; +Cc: petkan, linux-kernel, netdev, jgarzik
ACK :-)
cheers,
Petko
On Mon, 23 Jul 2007, Micah Gruber wrote:
> This patch fixes a potential null dereference bug where we dereference
> pegasus before a null check. This patch simply moves the dereferencing after
> the null check.
>
> Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
>
> ---
>
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -768,11 +768,13 @@
> static void write_bulk_callback(struct urb *urb)
> {
> pegasus_t *pegasus = urb->context;
> - struct net_device *net = pegasus->net;
> + struct net_device *net;
>
> if (!pegasus)
> return;
>
> + net = pegasus->net;
> +
> if (!netif_device_present(net) || !netif_running(net))
> return;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c
2007-07-23 8:05 [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c Micah Gruber
2007-07-24 12:57 ` Petko Manolov
@ 2007-07-30 19:45 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-07-30 19:45 UTC (permalink / raw)
To: Micah Gruber; +Cc: petkan, linux-kernel, netdev
Micah Gruber wrote:
> This patch fixes a potential null dereference bug where we dereference
> pegasus before a null check. This patch simply moves the dereferencing
> after the null check.
>
> Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
>
> ---
>
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -768,11 +768,13 @@
> static void write_bulk_callback(struct urb *urb)
> {
> pegasus_t *pegasus = urb->context;
> - struct net_device *net = pegasus->net;
> + struct net_device *net;
>
> if (!pegasus)
> return;
>
> + net = pegasus->net;
> +
applied (manually)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-30 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-23 8:05 [PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c Micah Gruber
2007-07-24 12:57 ` Petko Manolov
2007-07-30 19:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).