From: Brian Haley <brian.haley@hp.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, johannes@sipsolutions.net, netdev@vger.kernel.org
Subject: Re: [GENETLINK]: Fix race in genl_unregister_mc_groups()
Date: Tue, 24 Jul 2007 12:14:28 -0400 [thread overview]
Message-ID: <46A62564.3070006@hp.com> (raw)
In-Reply-To: <20070724094557.GE9285@postel.suug.ch>
Thomas Graf wrote:
> @@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
> void genl_unregister_mc_group(struct genl_family *family,
> struct genl_multicast_group *grp)
> {
> - BUG_ON(grp->family != family);
> genl_lock();
> - netlink_clear_multicast_users(genl_sock, grp->id);
> - clear_bit(grp->id, mc_groups);
> - list_del(&grp->list);
> - genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, grp);
> - grp->id = 0;
> - grp->family = NULL;
> + genl_unregister_mc_group(family, grp);
> genl_unlock();
> }
Shouldn't this be __genl_unregister_mc_group(family, grp) ?
-Brian
next prev parent reply other threads:[~2007-07-24 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 9:45 [GENETLINK]: Fix race in genl_unregister_mc_groups() Thomas Graf
2007-07-24 16:14 ` Brian Haley [this message]
2007-07-24 21:51 ` Thomas Graf
2007-07-24 21:52 ` [REPOST][GENETLINK]: " Thomas Graf
2007-07-24 22:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A62564.3070006@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).