* [2.6 patch] drivers/net/acenic.c: fix check-after-use
@ 2007-07-23 8:02 Adrian Bunk
2007-07-24 20:37 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-07-23 8:02 UTC (permalink / raw)
To: jes, Jeff Garzik; +Cc: linux-acenic, netdev, linux-kernel
The Coverity checker noted that we've already dereferenced "dev" when we
check whether it's NULL.
Since it's impossible that "dev" is NULL at this place this patch
removes the NULL check.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.22-rc6-mm1/drivers/net/acenic.c.old 2007-07-23 04:06:05.000000000 +0200
+++ linux-2.6.22-rc6-mm1/drivers/net/acenic.c 2007-07-23 04:08:11.000000000 +0200
@@ -3124,20 +3124,14 @@ static int __devinit read_eeprom_byte(st
struct ace_private *ap = netdev_priv(dev);
struct ace_regs __iomem *regs = ap->regs;
unsigned long flags;
u32 local;
int result = 0;
short i;
- if (!dev) {
- printk(KERN_ERR "No device!\n");
- result = -ENODEV;
- goto out;
- }
-
/*
* Don't take interrupts on this CPU will bit banging
* the %#%#@$ I2C device
*/
local_irq_save(flags);
eeprom_start(regs);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/net/acenic.c: fix check-after-use
2007-07-23 8:02 [2.6 patch] drivers/net/acenic.c: fix check-after-use Adrian Bunk
@ 2007-07-24 20:37 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-07-24 20:37 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jes, linux-acenic, netdev, linux-kernel
Adrian Bunk wrote:
> The Coverity checker noted that we've already dereferenced "dev" when we
> check whether it's NULL.
>
> Since it's impossible that "dev" is NULL at this place this patch
> removes the NULL check.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-24 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-23 8:02 [2.6 patch] drivers/net/acenic.c: fix check-after-use Adrian Bunk
2007-07-24 20:37 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).