From: Patrick McHardy <kaber@trash.net>
To: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc
Date: Wed, 25 Jul 2007 02:35:50 +0200 [thread overview]
Message-ID: <46A69AE6.9030009@trash.net> (raw)
In-Reply-To: <20070724223346.10658.80645.stgit@localhost.localdomain>
PJ Waskiewicz wrote:
> This is a patch from Patrick McHardy to fix the sch_api code, which I
> went ahead and tested and made a slight fix to. This also includes
> the fix to sch_prio based on Patrick's patch.
>
> The sch->parent handle should contain the parent qdisc ID. When the
> qdisc is the root qdisc (TC_H_ROOT), the parent handle should be the
> value TC_H_ROOT. This fixes sch_api to set this correctly on
> qdisc_create() for both ingress and egress qdiscs.
>
> Change this check in prio_tune() so that only the root qdisc can be
> multiqueue-enabled; use sch->parent instead of sch->handle.
Both look good, thanks.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2007-07-25 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 22:33 [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc PJ Waskiewicz
2007-07-24 22:33 ` [PATCH 1/2] NET: Fix sch_api to properly set sch->parent on " PJ Waskiewicz
2007-07-24 22:33 ` [PATCH 2/2] NET: Fix sch_prio to properly detect the root qdisc on multiqueue PJ Waskiewicz
2007-07-25 0:35 ` Patrick McHardy [this message]
2007-07-27 16:22 ` [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc Waskiewicz Jr, Peter P
2007-07-31 0:14 ` David Miller
2007-07-31 0:14 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A69AE6.9030009@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).