* [PATCH 2/4 -rev1] Add new timeval_to_sec function
@ 2007-07-26 5:15 Varun Chandramohan
2007-07-26 5:58 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Varun Chandramohan @ 2007-07-26 5:15 UTC (permalink / raw)
To: davem; +Cc: netdev, kaber, socketcan, shemminger, krkumar2
A new function for converting timeval to time_t is added in time.h. Its a common function used in different
places. The timeout is now rounded up as per the suggestion.
Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com>
---
include/linux/time.h | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/include/linux/time.h b/include/linux/time.h
index dda9be6..908329a 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
}
/**
+ * timeval_to_sec - Convert timeval to seconds
+ * @tv: pointer to the timeval variable to be converted
+ *
+ * Returns the seconds representation of timeval parameter.
+ */
+static inline time_t timeval_to_sec(const struct timeval *tv)
+{
+ return (tv->tv_sec + (tv->tv_usec + 999999)/1000000);
+}
+
+/**
* ns_to_timespec - Convert nanoseconds to timespec
* @nsec: the nanoseconds value to be converted
*
--
1.4.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function
2007-07-26 5:15 [PATCH 2/4 -rev1] Add new timeval_to_sec function Varun Chandramohan
@ 2007-07-26 5:58 ` Eric Dumazet
2007-07-26 6:17 ` Oliver Hartkopp
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2007-07-26 5:58 UTC (permalink / raw)
To: Varun Chandramohan; +Cc: davem, netdev, kaber, socketcan, shemminger, krkumar2
Varun Chandramohan a écrit :
> A new function for converting timeval to time_t is added in time.h. Its a common function used in different
> places. The timeout is now rounded up as per the suggestion.
>
> Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com>
> ---
> include/linux/time.h | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/time.h b/include/linux/time.h
> index dda9be6..908329a 100644
> --- a/include/linux/time.h
> +++ b/include/linux/time.h
> @@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
> }
>
> /**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv: pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> + return (tv->tv_sec + (tv->tv_usec + 999999)/1000000);
> +}
> +
> +/**
return tv->tv_sec + (tv->tv_usec ? 1 : 0);
is much faster
Also, the comment is not accurate, as it doesnt mention the roundup at all.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function
2007-07-26 5:58 ` Eric Dumazet
@ 2007-07-26 6:17 ` Oliver Hartkopp
0 siblings, 0 replies; 3+ messages in thread
From: Oliver Hartkopp @ 2007-07-26 6:17 UTC (permalink / raw)
To: Eric Dumazet
Cc: Varun Chandramohan, davem, netdev, kaber, socketcan, shemminger,
krkumar2
Eric Dumazet wrote:
> Varun Chandramohan a écrit :
>>
>> + return (tv->tv_sec + (tv->tv_usec + 999999)/1000000);
>
> return tv->tv_sec + (tv->tv_usec ? 1 : 0);
>
> is much faster
It additionally wins the design award in opposite to my suggestion ;-)
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-26 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-26 5:15 [PATCH 2/4 -rev1] Add new timeval_to_sec function Varun Chandramohan
2007-07-26 5:58 ` Eric Dumazet
2007-07-26 6:17 ` Oliver Hartkopp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).