From: Varun Chandramohan <varunc@linux.vnet.ibm.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kaber@trash.net,
socketcan@hartkopp.net, shemminger@linux-foundation.org,
krkumar2@in.ibm.com
Subject: Re: [PATCH 3/4 -rev1] Initilize and populate age field
Date: Thu, 26 Jul 2007 12:29:22 +0530 [thread overview]
Message-ID: <46A8464A.1020400@linux.vnet.ibm.com> (raw)
In-Reply-To: <46A84128.1090207@cosmosbay.com>
Eric Dumazet wrote:
> Varun Chandramohan a écrit :
>> Eric Dumazet wrote:
>>> Varun Chandramohan a écrit :
>>>> The age field is filled with the current time at the time of creation
>>>> of the route. When the routes are dumped
>>>> then the age value stored in the route structure is subtracted from
>>>> the current time value and the difference is the age expressed in
>>>> secs.
>>>>
>>>> }
>>>> +
>>>> + do_gettimeofday(&tv);
>>>> + if (!*age) {
>>>> + *age = timeval_to_sec(&tv);
>>>> + NLA_PUT_U32(skb, RTA_AGE, *age);
>>> here, what happens if sizeof(time_t) is not 4 ?
>>>
>> Same case as above :-) comments?
>
> So you are confident it (truncation from 8 to 4 bytes) works well on
> Big endian arches as well as Little endian arches ? :-)
>
I suppose so. But i must admit i have'nt tested it on Big endian arch
though!!!
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-07-26 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 5:15 [PATCH 3/4 -rev1] Initilize and populate age field Varun Chandramohan
2007-07-26 6:03 ` Eric Dumazet
2007-07-26 6:27 ` Varun Chandramohan
2007-07-26 6:37 ` Eric Dumazet
2007-07-26 6:59 ` Varun Chandramohan [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-07 4:52 Varun Chandramohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A8464A.1020400@linux.vnet.ibm.com \
--to=varunc@linux.vnet.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).