From: Patrick McHardy <kaber@trash.net>
To: Mitch Williams <mitch.a.williams@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] HW VLAN filtering control
Date: Mon, 30 Jul 2007 14:43:56 +0200 [thread overview]
Message-ID: <46ADDD0C.7020200@trash.net> (raw)
In-Reply-To: <1185569723.28574.8.camel@strongmad>
Mitch Williams wrote:
> This patchset adds the capability to disable hardware VLAN filtering at
> runtime via the existing vconfig utility. It's useful for debugging
> purposes.
>
> The first patch modifies the VLAN subsystem to define the flag, and to
> support passing the flag on to the base driver.
>
> The second patch modifies e1000 to support the flag. Since it's only
> one function, other drivers can be easily modified to support this
> functionality.
>
> vconfig is used without modification to enable or disable filtering:
> # vconfig [vlan-interface] 2 1
> will disable filtering, and
> # vconfig [vlan-interface] 2 0
> will enable filtering.
I think an ethtool option for this would be more consistent with
configuration of other device features and its questionable whether
new feature should be added to the ioctl interface at all. The
vlan driver could perform the necessary reconfiguration in the
FEAT_CHANGE notifier call.
prev parent reply other threads:[~2007-07-30 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 20:55 [PATCH 0/2] HW VLAN filtering control Mitch Williams
2007-07-27 21:06 ` Ben Greear
2007-07-27 21:23 ` Mitch Williams
2007-07-30 12:43 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ADDD0C.7020200@trash.net \
--to=kaber@trash.net \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).