* [PATCH 0/2] HW VLAN filtering control
@ 2007-07-27 20:55 Mitch Williams
2007-07-27 21:06 ` Ben Greear
2007-07-30 12:43 ` Patrick McHardy
0 siblings, 2 replies; 4+ messages in thread
From: Mitch Williams @ 2007-07-27 20:55 UTC (permalink / raw)
To: netdev
This patchset adds the capability to disable hardware VLAN filtering at
runtime via the existing vconfig utility. It's useful for debugging
purposes.
The first patch modifies the VLAN subsystem to define the flag, and to
support passing the flag on to the base driver.
The second patch modifies e1000 to support the flag. Since it's only
one function, other drivers can be easily modified to support this
functionality.
vconfig is used without modification to enable or disable filtering:
# vconfig [vlan-interface] 2 1
will disable filtering, and
# vconfig [vlan-interface] 2 0
will enable filtering.
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] HW VLAN filtering control
2007-07-27 20:55 [PATCH 0/2] HW VLAN filtering control Mitch Williams
@ 2007-07-27 21:06 ` Ben Greear
2007-07-27 21:23 ` Mitch Williams
2007-07-30 12:43 ` Patrick McHardy
1 sibling, 1 reply; 4+ messages in thread
From: Ben Greear @ 2007-07-27 21:06 UTC (permalink / raw)
To: Mitch Williams; +Cc: netdev
Mitch Williams wrote:
> This patchset adds the capability to disable hardware VLAN filtering at
> runtime via the existing vconfig utility. It's useful for debugging
> purposes.
>
> The first patch modifies the VLAN subsystem to define the flag, and to
> support passing the flag on to the base driver.
>
> The second patch modifies e1000 to support the flag. Since it's only
> one function, other drivers can be easily modified to support this
> functionality.
>
> vconfig is used without modification to enable or disable filtering:
> # vconfig [vlan-interface] 2 1
> will disable filtering, and
> # vconfig [vlan-interface] 2 0
> will enable filtering.
This looks fine to me.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] HW VLAN filtering control
2007-07-27 20:55 [PATCH 0/2] HW VLAN filtering control Mitch Williams
2007-07-27 21:06 ` Ben Greear
@ 2007-07-30 12:43 ` Patrick McHardy
1 sibling, 0 replies; 4+ messages in thread
From: Patrick McHardy @ 2007-07-30 12:43 UTC (permalink / raw)
To: Mitch Williams; +Cc: netdev
Mitch Williams wrote:
> This patchset adds the capability to disable hardware VLAN filtering at
> runtime via the existing vconfig utility. It's useful for debugging
> purposes.
>
> The first patch modifies the VLAN subsystem to define the flag, and to
> support passing the flag on to the base driver.
>
> The second patch modifies e1000 to support the flag. Since it's only
> one function, other drivers can be easily modified to support this
> functionality.
>
> vconfig is used without modification to enable or disable filtering:
> # vconfig [vlan-interface] 2 1
> will disable filtering, and
> # vconfig [vlan-interface] 2 0
> will enable filtering.
I think an ethtool option for this would be more consistent with
configuration of other device features and its questionable whether
new feature should be added to the ioctl interface at all. The
vlan driver could perform the necessary reconfiguration in the
FEAT_CHANGE notifier call.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-30 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-27 20:55 [PATCH 0/2] HW VLAN filtering control Mitch Williams
2007-07-27 21:06 ` Ben Greear
2007-07-27 21:23 ` Mitch Williams
2007-07-30 12:43 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).