* [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization
@ 2007-07-18 7:24 Denis Cheng
2007-07-21 1:22 ` Divy Le Ray
2007-07-30 20:04 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Denis Cheng @ 2007-07-18 7:24 UTC (permalink / raw)
To: linux-bugs
Cc: Andrew Morton, Jeff Garzik, netdev, cr_quan, Denis Cheng,
linux-bugs
Cc: linux-bugs@chelsio.com
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
drivers/net/cxgb3/cxgb3_main.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 6fd1e52..45711f9 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -754,7 +754,7 @@ static int upgrade_fw(struct adapter *adap)
*/
static int cxgb_up(struct adapter *adap)
{
- int err = 0;
+ int err;
if (!(adap->flags & FULL_INIT_DONE)) {
err = t3_check_fw_version(adap);
@@ -861,7 +861,7 @@ static int offload_open(struct net_device *dev)
struct adapter *adapter = dev->priv;
struct t3cdev *tdev = T3CDEV(dev);
int adap_up = adapter->open_device_map & PORT_MASK;
- int err = 0;
+ int err;
if (test_and_set_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map))
return 0;
@@ -1502,7 +1502,7 @@ static int set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
u8 * data)
{
u8 *buf;
- int err = 0;
+ int err;
u32 aligned_offset, aligned_len, *p;
struct adapter *adapter = dev->priv;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization
2007-07-18 7:24 [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization Denis Cheng
@ 2007-07-21 1:22 ` Divy Le Ray
2007-07-30 20:04 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Divy Le Ray @ 2007-07-21 1:22 UTC (permalink / raw)
To: Denis Cheng; +Cc: linux-bugs, Andrew Morton, Jeff Garzik, netdev, cr_quan
Denis Cheng wrote:
> Cc: linux-bugs@chelsio.com
> Signed-off-by: Denis Cheng <crquan@gmail.com>
>
Acked-by: Divy Le Ray <divy@chelsio.com>
> ---
> drivers/net/cxgb3/cxgb3_main.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index 6fd1e52..45711f9 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -754,7 +754,7 @@ static int upgrade_fw(struct adapter *adap)
> */
> static int cxgb_up(struct adapter *adap)
> {
> - int err = 0;
> + int err;
>
> if (!(adap->flags & FULL_INIT_DONE)) {
> err = t3_check_fw_version(adap);
> @@ -861,7 +861,7 @@ static int offload_open(struct net_device *dev)
> struct adapter *adapter = dev->priv;
> struct t3cdev *tdev = T3CDEV(dev);
> int adap_up = adapter->open_device_map & PORT_MASK;
> - int err = 0;
> + int err;
>
> if (test_and_set_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map))
> return 0;
> @@ -1502,7 +1502,7 @@ static int set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
> u8 * data)
> {
> u8 *buf;
> - int err = 0;
> + int err;
> u32 aligned_offset, aligned_len, *p;
> struct adapter *adapter = dev->priv;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization
2007-07-18 7:24 [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization Denis Cheng
2007-07-21 1:22 ` Divy Le Ray
@ 2007-07-30 20:04 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-07-30 20:04 UTC (permalink / raw)
To: Denis Cheng; +Cc: linux-bugs, Andrew Morton, netdev, cr_quan
Denis Cheng wrote:
> Cc: linux-bugs@chelsio.com
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> drivers/net/cxgb3/cxgb3_main.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-30 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-18 7:24 [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization Denis Cheng
2007-07-21 1:22 ` Divy Le Ray
2007-07-30 20:04 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).