netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Moni Shoua <monisonlists@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: fubar@us.ibm.com, davem@davemloft.net,
	general@lists.openfabrics.org, netdev@vger.kernel.org
Subject: Re: [ofa-general] Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for	the bonding driver
Date: Tue, 31 Jul 2007 16:44:08 +0300	[thread overview]
Message-ID: <46AF3CA8.6050201@gmail.com> (raw)
In-Reply-To: <adaejipr3l5.fsf@cisco.com>

Roland Dreier wrote:
>  > 1. When bonding enslaves an IPoIB device the bonding neighbor holds a 
>  > reference to a cleanup function in the IPoIB drives. This makes it unsafe to 
>  > unload the IPoIB module if there are bonding neighbors in the air. So, to 
>  > avoid this race one must unload bonding before unloading IPoIB. 
> 
> I think we really want to resolve this somehow.  Getting an oops by
> doing "modprobe -r ipoib" isn't that friendly.
> 
You are right and we want to resolve that.
One way is to clean the neigh destructor function from all IPoIB neighs.
The other way is to prevent ipoib unload if device is a slave or is referenced from 
somewhere else.

I guess I would like an advice here.
> Also, what happened to the problem of having an address handle
> belonging to the wrong device on bond failover?  Did you figure out a
> way to fix that one?
This is what patch 2 handles.
> 
>  - R.
> _______________________________________________
> general mailing list
> general@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 

  reply	other threads:[~2007-07-31 13:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 12:37 [ofa-general] [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-07-30 12:48 ` [ofa-general] [PATCH V3 1/7] IB/ipoib: Bound the net device to the ipoib_neigh structue Moni Shoua
2007-07-30 12:49 ` [ofa-general] [PATCH V3 2/7] IB/ipoib: Verify address handle validity on send Moni Shoua
2007-07-30 12:51 ` [ofa-general] [PATCH V3 3/7] net/bonding: Enable bonding to enslave non ARPHRD_ETHER Moni Shoua
2007-07-30 12:52 ` [ofa-general] [PATCH V3 4/7] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address() Moni Shoua
2007-07-30 12:54 ` [ofa-general] [PATCH V3 5/7] net/bonding: Enable IP multicast for bonding IPoIB devices Moni Shoua
2007-07-30 12:54 ` [ofa-general] [PATCH V3 6/7] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device Moni Shoua
2007-07-30 12:56 ` [ofa-general] [PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure Moni Shoua
2007-07-30 20:29   ` [ofa-general] " Jay Vosburgh
2007-07-31 13:33     ` Moni Shoua
2007-07-30 21:20 ` [PATCH V3 0/7] net/bonding: ADD IPoIB support for the bonding driver Roland Dreier
2007-07-31 13:44   ` Moni Shoua [this message]
2007-07-31 14:04     ` [ofa-general] Re: " Michael S. Tsirkin
2007-07-31 14:19       ` Or Gerlitz
2007-07-31 14:22         ` [ofa-general] " Michael S. Tsirkin
2007-07-31 14:36           ` Or Gerlitz
2007-07-31 14:48             ` Michael S. Tsirkin
2007-07-31 14:57               ` [ofa-general] " Or Gerlitz
2007-08-01 14:12           ` [ofa-general] Re: " Moni Shoua
2007-08-01 16:10             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AF3CA8.6050201@gmail.com \
    --to=monisonlists@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).