netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <teheo@suse.de>
To: Brandon Philips <brandon@suse.de>
Cc: netdev@vger.kernel.org, Brandon Philips <bphilips@suse.de>
Subject: Re: [patch 2/5][RFC] Update net core to use devres.
Date: Fri, 03 Aug 2007 18:13:29 +0900	[thread overview]
Message-ID: <46B2F1B9.9010605@suse.de> (raw)
In-Reply-To: <20070802224527.GD5181@ifup.org>

> +static inline void * register_netdev_devres(struct device *gendev,
> +						struct net_device *dev)
> +{
> +	struct net_device **p;
> +
> +	/* 0 size because we don't need it. The net_device is already alloc'd
> +	 * in alloc_netdev_mq.  We can't use devm_kzalloc in alloc_netdeev_mq
> +	 * because a net_device cannot be free'd directly as it can be a
> +	 * kobject.  See free_netdev.
> +	 */
> +	p = devres_alloc(devm_free_netdev, 0, GFP_KERNEL);

s/0/sizeof(*p)/

-- 
tejun

  reply	other threads:[~2007-08-03  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 22:45 [patch 2/5][RFC] Update net core to use devres Brandon Philips
2007-08-03  9:13 ` Tejun Heo [this message]
2007-08-03  9:39   ` Brandon Philips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B2F1B9.9010605@suse.de \
    --to=teheo@suse.de \
    --cc=bphilips@suse.de \
    --cc=brandon@suse.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).