From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
Jeff Garzik <jgarzik@pobox.com>, NetDev <netdev@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@linux.intel.com>,
"Ronciak, John" <john.ronciak@intel.com>
Subject: Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only)
Date: Mon, 06 Aug 2007 21:25:05 -0700 [thread overview]
Message-ID: <46B7F421.1020509@intel.com> (raw)
In-Reply-To: <p737io8caai.fsf@bingen.suse.de>
Andi Kleen wrote:
> "Kok, Auke" <auke-jan.h.kok@intel.com> writes:
>
>> All,
>>
>> Another update on e1000e. Many thanks to Jeff for helping out and
>> getting this going forward. The driver is unfortunately still too
>> large to post, so please use the URL's below to review:
>
> Just some things I noticed; no comprehensive review
thanks, quick reply to one of the issues below, others I'll take into account
and look into deeper.
> + mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
> Should use round_jiffies to avoid wakeups
actually, not here - we don't want the led to blink unreliably. If the timer
gets stalled beyond 1/2 a second and is irregular, you'll never be able to
identify the proper adapter port in you data center.
remember, this is only used once the user invokes 'ethtool -p'
Auke
next prev parent reply other threads:[~2007-08-07 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 21:57 [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only) Kok, Auke
2007-08-07 3:07 ` Andi Kleen
2007-08-07 4:25 ` Kok, Auke [this message]
2007-08-07 5:37 ` Arjan van de Ven
2007-08-10 20:17 ` Kok, Auke
2007-08-07 16:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B7F421.1020509@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=akpm@osdl.org \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).