* [PATCH] drivers/net/ibmveth.c: memset fix
@ 2007-08-06 20:17 Mariusz Kozlowski
2007-08-06 20:37 ` Brian King
0 siblings, 1 reply; 6+ messages in thread
From: Mariusz Kozlowski @ 2007-08-06 20:17 UTC (permalink / raw)
To: santil, jgarzik; +Cc: netdev, linux-kernel
Hello,
Looks like memset() is zeroing wrong nr of bytes.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/net/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c 2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c 2007-08-06 20:34:44.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
{
int rc, i;
struct net_device *netdev;
- struct ibmveth_adapter *adapter = NULL;
+ struct ibmveth_adapter *adapter;
unsigned char *mac_addr_p;
unsigned int *mcastFilterSize_p;
@@ -997,7 +997,7 @@ static int __devinit ibmveth_probe(struc
SET_MODULE_OWNER(netdev);
adapter = netdev->priv;
- memset(adapter, 0, sizeof(adapter));
+ memset(adapter, 0, sizeof(*adapter));
dev->dev.driver_data = netdev;
adapter->vdev = dev;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/net/ibmveth.c: memset fix
2007-08-06 20:17 [PATCH] drivers/net/ibmveth.c: memset fix Mariusz Kozlowski
@ 2007-08-06 20:37 ` Brian King
2007-08-06 20:44 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Brian King @ 2007-08-06 20:37 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: santil, jgarzik, netdev, linux-kernel
Mariusz Kozlowski wrote:
> Hello,
>
> Looks like memset() is zeroing wrong nr of bytes.
Good catch, however, I think we can just remove this memset altogether
since the memory gets allocated via kzalloc.
-Brian
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/ibmveth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c 2007-08-01 08:43:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c 2007-08-06 20:34:44.000000000 +0200
> @@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
> {
> int rc, i;
> struct net_device *netdev;
> - struct ibmveth_adapter *adapter = NULL;
> + struct ibmveth_adapter *adapter;
>
> unsigned char *mac_addr_p;
> unsigned int *mcastFilterSize_p;
> @@ -997,7 +997,7 @@ static int __devinit ibmveth_probe(struc
> SET_MODULE_OWNER(netdev);
>
> adapter = netdev->priv;
> - memset(adapter, 0, sizeof(adapter));
> + memset(adapter, 0, sizeof(*adapter));
> dev->dev.driver_data = netdev;
>
> adapter->vdev = dev;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/net/ibmveth.c: memset fix
2007-08-06 20:37 ` Brian King
@ 2007-08-06 20:44 ` Jeff Garzik
2007-08-06 21:44 ` Mariusz Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-08-06 20:44 UTC (permalink / raw)
To: brking; +Cc: Mariusz Kozlowski, santil, netdev, linux-kernel
Brian King wrote:
> Mariusz Kozlowski wrote:
>> Hello,
>>
>> Looks like memset() is zeroing wrong nr of bytes.
>
> Good catch, however, I think we can just remove this memset altogether
> since the memory gets allocated via kzalloc.
Correct, that memset() is superfluous.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ibmveth.c: memset fix
2007-08-06 20:44 ` Jeff Garzik
@ 2007-08-06 21:44 ` Mariusz Kozlowski
2007-08-07 15:40 ` Brian King
2007-08-07 21:36 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Mariusz Kozlowski @ 2007-08-06 21:44 UTC (permalink / raw)
To: Jeff Garzik; +Cc: brking, santil, netdev, linux-kernel
> >> Looks like memset() is zeroing wrong nr of bytes.
> >
> > Good catch, however, I think we can just remove this memset altogether
> > since the memory gets allocated via kzalloc.
>
> Correct, that memset() is superfluous.
Ok. Then this should do it.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/net/ibmveth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c 2007-08-01 08:43:46.000000000 +0200
+++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c 2007-08-06 23:32:13.000000000 +0200
@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
{
int rc, i;
struct net_device *netdev;
- struct ibmveth_adapter *adapter = NULL;
+ struct ibmveth_adapter *adapter;
unsigned char *mac_addr_p;
unsigned int *mcastFilterSize_p;
@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struc
SET_MODULE_OWNER(netdev);
adapter = netdev->priv;
- memset(adapter, 0, sizeof(adapter));
dev->dev.driver_data = netdev;
adapter->vdev = dev;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/net/ibmveth.c: memset fix
2007-08-06 21:44 ` Mariusz Kozlowski
@ 2007-08-07 15:40 ` Brian King
2007-08-07 21:36 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Brian King @ 2007-08-07 15:40 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Jeff Garzik, santil, netdev, linux-kernel
Mariusz Kozlowski wrote:
>>>> Looks like memset() is zeroing wrong nr of bytes.
>>> Good catch, however, I think we can just remove this memset altogether
>>> since the memory gets allocated via kzalloc.
>> Correct, that memset() is superfluous.
>
> Ok. Then this should do it.
Acked-by: Brian King <brking@linux.vnet.ibm.com>
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/ibmveth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c 2007-08-01 08:43:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm2-b/drivers/net/ibmveth.c 2007-08-06 23:32:13.000000000 +0200
> @@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struc
> {
> int rc, i;
> struct net_device *netdev;
> - struct ibmveth_adapter *adapter = NULL;
> + struct ibmveth_adapter *adapter;
>
> unsigned char *mac_addr_p;
> unsigned int *mcastFilterSize_p;
> @@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struc
> SET_MODULE_OWNER(netdev);
>
> adapter = netdev->priv;
> - memset(adapter, 0, sizeof(adapter));
> dev->dev.driver_data = netdev;
>
> adapter->vdev = dev;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/net/ibmveth.c: memset fix
2007-08-06 21:44 ` Mariusz Kozlowski
2007-08-07 15:40 ` Brian King
@ 2007-08-07 21:36 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2007-08-07 21:36 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: brking, santil, netdev, linux-kernel
Mariusz Kozlowski wrote:
>>>> Looks like memset() is zeroing wrong nr of bytes.
>>> Good catch, however, I think we can just remove this memset altogether
>>> since the memory gets allocated via kzalloc.
>> Correct, that memset() is superfluous.
>
> Ok. Then this should do it.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/ibmveth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-07 21:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-06 20:17 [PATCH] drivers/net/ibmveth.c: memset fix Mariusz Kozlowski
2007-08-06 20:37 ` Brian King
2007-08-06 20:44 ` Jeff Garzik
2007-08-06 21:44 ` Mariusz Kozlowski
2007-08-07 15:40 ` Brian King
2007-08-07 21:36 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).