Netdev List
 help / color / mirror / Atom feed
From: John Heffner <jheffner@psc.edu>
To: David Miller <davem@davemloft.net>
Cc: ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org
Subject: Re: TCP's initial cwnd setting correct?...
Date: Wed, 08 Aug 2007 11:20:05 -0400	[thread overview]
Message-ID: <46B9DF25.3000800@psc.edu> (raw)
In-Reply-To: <20070807.182823.123919803.davem@davemloft.net>

I believe the current calculation is correct.  The RFC specifies a 
window of no more than 4380 bytes unless 2*MSS > 4380.  If you change 
the code in this way, then MSS=1461 will give you an initial window of 
3*MSS == 4383, violating the spec.  Reading the pseudocode in the RFC 
3390 is a bit misleading because they use a clamp at 4380 bytes rather 
than use a multiplier in the relevant range.

   -John


David Miller wrote:
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Mon, 6 Aug 2007 15:37:15 +0300 (EEST)
> 
>> @@ -805,13 +805,13 @@ void tcp_update_metrics(struct sock *sk)
>>  	}
>>  }
>>  
>> -/* Numbers are taken from RFC2414.  */
>> +/* Numbers are taken from RFC3390.  */
>>  __u32 tcp_init_cwnd(struct tcp_sock *tp, struct dst_entry *dst)
>>  {
>>  	__u32 cwnd = (dst ? dst_metric(dst, RTAX_INITCWND) : 0);
>>  
>>  	if (!cwnd) {
>> -		if (tp->mss_cache > 1460)
>> +		if (tp->mss_cache >= 2190)
>>  			cwnd = 2;
>>  		else
>>  			cwnd = (tp->mss_cache > 1095) ? 3 : 4;
> 
> I remember suggesting something similar about 5 or 6 years
> ago and Alexey Kuznetsov at the time explained the numbers
> which are there and why they should not be changed.
> 
> I forget the reasons though, and I'll try to do the research.
> 
> These numbers have been like this forever, FWIW.
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2007-08-08 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 12:37 TCP's initial cwnd setting correct? Ilpo Järvinen
2007-08-06 18:31 ` Ilpo Järvinen
2007-08-08 15:26   ` John Heffner
2007-08-08  1:28 ` David Miller
2007-08-08 15:20   ` John Heffner [this message]
2007-08-09  4:40     ` David Miller
2007-08-08  5:01 ` David Miller
2007-08-08 13:05   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B9DF25.3000800@psc.edu \
    --to=jheffner@psc.edu \
    --cc=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox