From: Aurelien Jarno <aurelien@aurel32.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] SSB PCI core driver fixes
Date: Thu, 09 Aug 2007 02:38:24 +0200 [thread overview]
Message-ID: <46BA6200.4060306@aurel32.net> (raw)
In-Reply-To: <200708090227.06510.mb@bu3sch.de>
Michael Buesch a écrit :
> On Thursday 09 August 2007, Aurelien Jarno wrote:
>> - Add some delay between the configuration of the PCI controller
>> and its registration.
>
> Why? It is _huge_ and people won't like it ;)
> At least add a comment why this is needed.
It is need, otherwise the PCI controller gets confused, which causes a
reset of the machine. Then CFE goes into a loop booting again and again
without being able to get up to the prompt.
I agree this is a huge value, so I will try to find the minimum value
and then add some margin.
I will send an updated patch.
>> @@ -340,6 +345,7 @@
>> * The following needs change, if we want to port hostmode
>> * to non-MIPS platform. */
>> set_io_port_base((unsigned long)ioremap_nocache(SSB_PCI_MEM, 0x04000000));
>> + mdelay(300);
>> register_pci_controller(&ssb_pcicore_controller);
>> }
>>
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2007-08-09 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 0:23 [PATCH] SSB PCI core driver fixes Aurelien Jarno
2007-08-09 0:27 ` Michael Buesch
2007-08-09 0:38 ` Aurelien Jarno [this message]
2007-08-09 1:09 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2007-08-09 10:10 [PATCH] ssb: pci " Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BA6200.4060306@aurel32.net \
--to=aurelien@aurel32.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).